Skip to content

feat: allow bool + number tag values #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 1, 2025
Merged

feat: allow bool + number tag values #160

merged 6 commits into from
Jul 1, 2025

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Jun 27, 2025 •
edited
Loading

Tag values accept bool & number in coder/coder.

Maps, lists, and objects are rejected as invalid tags. terraform apply gives this error for

data "coder_workspace_tags" "custom_workspace_tags" {
  tags = {
    "map"    = {
      "value" = "foo"
    }
  }
}
╷
│ Error: Incorrect attribute value type
│ 
│   on main.tf line 11, in data "coder_workspace_tags" "custom_workspace_tags":
│   11:   tags = {
│   12:     "list"   = ["a", "b", "c"]
│   13:   }
│ 
│ Inappropriate value for attribute "tags": element "list": string required.
╵

null values are omitted from the tags, matching terraform apply/plan

@Emyrk
feat: allow bool + number tag values
849c539 
Tag values accept bool & number in coder/coder.
@Emyrk Emyrk requested a review from johnstcn June 27, 2025 17:41
@Emyrk Emyrk marked this pull request as draft June 30, 2025 12:19
@Emyrk Emyrk marked this pull request as ready for review June 30, 2025 16:04
Emyrk
Emyrk commented Jun 30, 2025
View reviewed changes
johnstcn
johnstcn approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@Emyrk Emyrk merged commit 25471dd into main Jul 1, 2025
3 checks passed
@Emyrk Emyrk deleted the stevenmasley/tag_types branch July 1, 2025 13:35
SasSwart pushed a commit that referenced this pull request Jul 13, 2025
@Emyrk @SasSwart
feat: allow bool + number tag values (#160)
8c86272 
Tag values accept bool & number in coder/coder.
Maps, lists, and objects are rejected as invalid tags. 
`null` values are omitted from the tags, matching terraform apply/plan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emyrk @johnstcn