drop dependency on abandoned package laravelcollective/html

- move columnSort() into helpers.php and return HtmlString object directly, and drop TotemFormServiceProvider
- replace Form::{method}() calls with manual form markup
- update TestCase accordingly

Author: jonnott

composer.json

@@ -24,8 +24,7 @@
     "illuminate/contracts": "^9.0|^10.0",
     "illuminate/database": "^9.0|^10.0",
     "illuminate/events": "^9.0|^10.0",
-    "illuminate/notifications": "^9.0|^10.0",
-    "laravelcollective/html": "^6.0"
+    "illuminate/notifications": "^9.0|^10.0"
   },
   "require-dev": {
     "mockery/mockery": "^1.0",
@@ -40,7 +39,10 @@
       "Studio\\Totem\\": "src/",
       "Studio\\Totem\\Tests\\": "tests/",
       "Database\\Factories\\": "database/factories/"
-    }
+    },
+    "files": [
+      "src/helpers.php"
+    ]
   },
   "extra": {
     "component": "package",

resources/views/tasks/index.blade.php

@@ -6,24 +6,29 @@
 @section('title')
     <div class="uk-flex uk-flex-between uk-flex-middle">
         <h4 class="uk-card-title uk-margin-remove">Tasks</h4>
-        {!! Form::open([
-            'id' => 'totem__search__form',
-            'url' => Request::fullUrl(),
-            'method' => 'GET',
-            'class' => 'uk-display-inline uk-search uk-search-default'
-        ]) !!}
-        <span uk-search-icon></span>
-        {!! Form::text('q', request('q'), ['class' => 'uk-search-input', 'placeholder' => 'Search...']) !!}
-        {!! Form::close() !!}
+        <form
+            accept-charset="UTF-8"
+            method="GET"
+            action="{{ request()->fullUrl() }}"
+            id="totem__search__form"
+            class="uk-display-inline uk-search uk-search-default">
+            <span uk-search-icon></span>
+            <input
+                value="{{ request('q') }}"
+                placeholder="Search..."
+                name="q"
+                type="text"
+                class="uk-search-input">
+        </form>
     </div>
 @stop
 @section('main-panel-content')
     <table class="uk-table uk-table-responsive" cellpadding="0" cellspacing="0" class="mb1">
         <thead>
             <tr>
-                <th>{!! Html::columnSort('Description', 'description') !!}</th>
-                <th>{!! Html::columnSort('Average Runtime', 'average_runtime') !!}</th>
-                <th>{!! Html::columnSort('Last Run', 'last_ran_at') !!}</th>
+                <th>{!! \Studio\Totem\Helpers\columnSort('Description', 'description') !!}</th>
+                <th>{!! \Studio\Totem\Helpers\columnSort('Average Runtime', 'average_runtime') !!}</th>
+                <th>{!! \Studio\Totem\Helpers\columnSort('Last Run', 'last_ran_at') !!}</th>
                 <th>Next Run</th>
                 <th class="uk-text-center">Execute</th>
             </tr>

src/Providers/TotemFormServiceProvider.php

@@ -65,7 +65,6 @@ public function register()
         $this->app->alias('totem.tasks', TaskInterface::class);
         $this->app->register(TotemRouteServiceProvider::class);
         $this->app->register(TotemEventServiceProvider::class);
-        $this->app->register(TotemFormServiceProvider::class);
         $this->app->register(ConsoleServiceProvider::class);
     }
 

src/Providers/TotemServiceProvider.php

@@ -0,0 +1,45 @@
+<?php
+
+namespace Studio\Totem\Helpers;
+
+use Illuminate\Support\HtmlString;
+
+function columnSort(string $label, string $columnKey, bool $isDefault = false)
+{
+    $icon = '';
+
+    if (request()->has('sort_by')) {
+        if (request()->input('sort_by') == $columnKey) {
+            $icon = ' <span class="fa fa-caret-'
+                .(request()->input('sort_direction', 'asc') == 'asc' ? 'up' : 'down')
+                .'"></span>';
+        }
+    } elseif ($isDefault) {
+        $icon = ' <span class="fa fa-caret-'
+            .(request()->input('sort_direction', 'asc') == 'asc' ? 'up' : 'down')
+            .'"></span>';
+    }
+
+    $order = 'asc';
+    if (request()->has('sort_direction')) {
+        $order = (request()->input('sort_direction') == 'desc' ? 'asc' : 'desc');
+    } elseif ($isDefault) {
+        $order = 'desc';
+    }
+
+    $url = request()->fullUrlWithQuery([
+        'sort_by' => $columnKey,
+        'sort_direction' => $order,
+        'filter' => request('filter'),
+        'limit' => request('limit'),
+    ]);
+
+    return new HtmlString(
+        '<a href="'
+        .$url
+        .'">'
+        .$label
+        .$icon
+        .'</a>'
+    );
+}

src/helpers.php

@@ -2,9 +2,6 @@
 
 namespace Studio\Totem\Tests;
 
-use Collective\Html\FormFacade;
-use Collective\Html\HtmlFacade;
-use Collective\Html\HtmlServiceProvider;
 use Illuminate\Contracts\Debug\ExceptionHandler;
 use Illuminate\Support\Facades\Auth;
 use Orchestra\Testbench\Exceptions\Handler;
@@ -47,25 +44,16 @@ protected function getEnvironmentSetUp($app)
     {
         $app['config']->set('database.default', 'testing');
         $app['config']->set('database.connections.testing', [
-            'driver'   => 'sqlite',
+            'driver' => 'sqlite',
             'database' => ':memory:',
-            'prefix'   => '',
+            'prefix' => '',
         ]);
     }
 
-    protected function getPackageAliases($app)
-    {
-        return [
-            'Form' => FormFacade::class,
-            'Html' => HtmlFacade::class,
-        ];
-    }
-
     protected function getPackageProviders($app)
     {
         return [
             TotemServiceProvider::class,
-            HtmlServiceProvider::class,
         ];
     }