Improve build script: Add error handling and DRY cleanup #688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Summary
This PR improves the build script by:
os.system(...)
calls with a reusablerun_cmd()
function.argparse
withaction='store_true'
for the--clean
flag (instead oftype=bool
).🔍 Why?
Previously, if any command in the build process failed, the script would still exit with code 0 — potentially causing CI to pass despite an error. This PR fixes that and makes the script cleaner and more maintainable.
📦 Affected script
scripts/build/install.py
(or whichever file contains the build logic)🧪 How to test
Try breaking a command manually — the script should exit with an error.