Incorrect LSP detection

[le4ker]

Thank you for Dotfyle, it's great!

One potential bug is that it can't detect all language servers, at least in my config.
For example here it detects the following language servers:

• tflint
• html
• clangd
• marksman
• gopls
• graphql
• pyright

And it's missing the following ones:

• bash-language-server
• terraform-ls
• tsserver
• lua_ls
• yamlls

Even though they seem to be included in the known language servers.

Also it detects html and graphql as a language servers even though I haven't set any such LSPs.
That maybe an issue with the known language servers, since I can't find an LSP named html or graphql in Mason 😅

[le4ker]

Opened a PR in case the html and graphql must be removed.

[le4ker]

Seems like it might be parsing the mason.lua file but not the lspconfig.lua?
Because all the missing LSPs are in my lspconfig, but they have a different name in the Mason config 😄

[codicocodes]

html and graphql are taken from here: https://github.com/neovim/nvim-lspconfig/blob/master/doc/server_configurations.md not from mason

[le4ker]

@codicocodes thank you, I closed my PR. Why does dotfyle detect those LSPs though in my case? Also why aren't the rest LSPs detected, even though they are defined in the known language servers?

[codicocodes]

Detection is looking for the string 'html' or 'graphql' in your config, this works for most language servers pretty well, but for html could easily have false positives. Here is your HTML setup btw, so it is not a false positive I believe: https://github.com/le4ker/nvim-config/blob/v2.0/lua/custom/configs/lspconfig.lua#L40-L43 The graphql one could be a false positive.

Not sure about why some are not detected though, it looks like that could very well be a bug.

[le4ker]

Yeah I added the html LSP a couple of days ago, but it was a false positive like graphql before that.

I noticed as well that in the code it just greps for the strings, so it's strange indeed that it can't detect some LSPs 🤔

[iainsimmons]

Part of the issue here is that there's two different names used for some language servers, and Mason's ensure_installed takes a different format than the ones in the known language servers.

See https://github.com/iainsimmons/nvim-config/blob/main/lua/plugins/lsp.lua#L182-L202

Also, you might get some false positives if the LSP name is matched in a code comment, such as for those using the linting setup from kickstart.nvim.

Or if the filename matches the name of the language server (as was the case for astro, html and svelte in my config) and is used elsewhere (e.g. for my emmet_ls config).

My first pass with Dotfyle generated the following:

• astro
• glint
• html
• lemminx
• marksman
• svelte
• tflint

Some of which are the ones that don't use a different format for the language server name.

Here are some that are different (Mason / LSP Config):

• "astro-language-server" / "astro"
• "emmet-ls" / "emmet_ls"
• "eslint-lsp" / "eslint"
• "html-lsp" / "html"
• "htmx-lsp" / "htmx"
• "json-lsp" / "jsonls"
• "lua-language-server" / "lua_ls"
• "svelte-language-server" / "svelte"
• "tailwindcss-language-server" / "tailwindcss"
• "typescript-language-server" / "tsserver"
• "yaml-language-server" / "yamlls"

So you almost need to match all the Mason strings too.

[greggh]

Adding to this, it only found html in my config, but I have 22 language servers in my config and all are installed by Mason.

This is the code in my lsp.lua (which is working fine)

  config = function()
    ---------------------
    -- lsp servers
    ---------------------
    local servers = {
      astro = {},
      bashls = {},
      cssls = {},
      docker_compose_language_service = {},
      dockerls = {},
      emmet_language_server = {
        filetypes = { "html", "typescriptreact", "javascriptreact", "css", "sass", "scss" },
      },
      eslint = {
        root_dir = vim.fs.root(0, { "package.json", ".eslintrc.json", ".eslintrc.js", ".git" }),
        filetypes = { "javascript", "typescript", "typescriptreact", "javascriptreact" },
        flags = os.getenv("DEBOUNCE_ESLINT") and {
          allow_incremental_sync = true,
          debounce_text_changes = 1000,
        } or nil,
        on_attach = function(_, bufnr)
          vim.api.nvim_create_autocmd("BufWritePre", {
            buffer = bufnr,
            command = "EslintFixAll",
          })
        end,
      },
      eslint_d = {
        root_dir = vim.fs.root(0, { "package.json", ".eslintrc.json", ".eslintrc.js", ".git" }),
        filetypes = { "javascript", "typescript", "typescriptreact", "javascriptreact" },
        flags = os.getenv("DEBOUNCE_ESLINT") and {
          allow_incremental_sync = true,
          debounce_text_changes = 1000,
        } or nil,
        on_attach = function(_, bufnr)
          vim.api.nvim_create_autocmd("BufWritePre", {
            buffer = bufnr,
            command = "EslintFixAll",
          })
        end,
      },
      gopls = {},
      html = {},
      jsonls = {},
      lua_ls = {
        settings = {
          Lua = {
            completion = {
              callSnippet = "Replace",
            },
          },
        },
      },
      --nil_ls = {},
      pyright = {},
      ruff = {
        on_attach = function(client)
          client.server_capabilities.hoverProvider = false
        end,
      },
      rust_analyzer = {},
      sqls = {},
      taplo = {
        filetypes = { "toml" },
        settings = {
          evenBetterToml = {
            formatter = {
              inlineTableExpand = false,
            },
          },
        },
      },
      ols = {},
      tailwindcss = {},
      vtsls = {
        root_dir = vim.fs.root(0, { "package.json", "tsconfig.json", "jsconfig.json", ".git" }),
        filetypes = {
          "javascript",
          "javascriptreact",
          "javascript.jsx",
          "typescript",
          "typescriptreact",
          "typescript.tsx",
        },
        settings = {
          complete_function_calls = true,
          vtsls = {
            enableMoveToFileCodeAction = true,
            autoUseWorkspaceTsdk = true,
            experimental = {
              maxInlayHintLength = 30,
              completion = {
                enableServerSideFuzzyMatch = true,
              },
            },
          },
          javascript = {
            updateImportsOnFileMove = { enabled = "always" },
            suggest = {
              completeFunctionCalls = true,
            },
          },
          typescript = {
            updateImportsOnFileMove = { enabled = "always" },
            suggest = {
              completeFunctionCalls = true,
            },
            inlayHints = {
              enumMemberValues = { enabled = true },
              functionLikeReturnTypes = { enabled = true },
              parameterNames = { enabled = "literals" },
              parameterTypes = { enabled = true },
              propertyDeclarationTypes = { enabled = true },
              variableTypes = { enabled = false },
            },
          },
        },
      },
      yamlls = {},
      zls = {},
    }

[le4ker]

@codicocodes did you make any updates related to this issue? It seems like it’s detecting way more than before 😁