Fix flake warnings

Author: MDUYN

investing_algorithm_framework/__init__.py

@@ -78,4 +78,4 @@
     "Context",
     "APPLICATION_DIRECTORY",
     "download"
-]
+]

investing_algorithm_framework/domain/data_provider.py

@@ -1,4 +1,4 @@
-from typing import Optional, List
+from typing import List
 from abc import ABC, abstractmethod
 from datetime import datetime
 from investing_algorithm_framework.domain import TradingDataType, TimeFrame
@@ -45,9 +45,9 @@ def __init__(
         symbol: str = None,
         markets: list = None,
         priority: int = 0,
-        time_frame = None,
-        window_size = None,
-        storage_path = None,
+        time_frame=None,
+        window_size=None,
+        storage_path=None,
         market_credentials: List = None,
     ):
         """
@@ -113,7 +113,7 @@ def has_data(
         time_frame: str = None,
         start_date: datetime = None,
         end_date: datetime = None,
-        window_size = None,
+        window_size=None,
     ) -> None:
         """
         Checks if the data provider has data for the given parameters.
@@ -130,9 +130,9 @@ def get_data(
         time_frame: str = None,
         start_date: datetime = None,
         end_date: datetime = None,
-        storage_path = None,
-        window_size = None,
-        pandas = False,
+        storage_path=None,
+        window_size=None,
+        pandas=False,
     ):
         """
         Fetches data for a given symbol and date range.
@@ -147,7 +147,7 @@ def pre_pare_backtest_data(
         symbol: str = None,
         market: str = None,
         time_frame: str = None,
-        window_size = None,
+        window_size=None,
     ) -> None:
         """
         Prepares backtest data for a given symbol and date range.
@@ -163,8 +163,8 @@ def get_backtest_data(
         time_frame: str = None,
         backtest_start_date: datetime = None,
         backtest_end_date: datetime = None,
-        window_size = None,
-        pandas = False,
+        window_size=None,
+        pandas=False,
     ) -> None:
         """
         Fetches backtest data for a given symbol and date range.

investing_algorithm_framework/domain/exceptions.py

@@ -61,6 +61,7 @@ def to_response(self):
             "message": self.error_message
         }
 
+
 class NetworkError(Exception):
     """
     Class NetworkError: Exception class indicating a problem occurred

investing_algorithm_framework/domain/models/backtesting/backtest_report.py

@@ -1,4 +1,4 @@
-from typing import List, Set, Dict
+from typing import List, Set
 from datetime import datetime
 from logging import getLogger
 
@@ -503,17 +503,6 @@ def from_dict(data):
 
         return report
 
-    def get_trades(self, symbol=None):
-        """
-        Function to get trades. If a symbol is provided, it will
-        return the trades for that symbol. If no symbol is provided,
-        it will return all the trades.
-        """
-        if symbol is None:
-            return self.trades
-
-        return [trade for trade in self.trades if trade.symbol == symbol]
-
     def get_profit(self) -> float:
         return self._total_net_gain
 
@@ -635,7 +624,6 @@ def get_orders(
                 if order.created_at < created_at_lt
             ]
 
-
         if target_symbol is not None:
             selection = [
                 order for order in selection
@@ -700,7 +688,6 @@ def get_symbols(self) -> Set[str]:
         """
         unique_symbols = set()
 
-
         for order in self.orders:
             if order.target_symbol not in self.symbols:
                 unique_symbols.add(order.target_symbol)

investing_algorithm_framework/domain/order_executor.py

@@ -29,8 +29,7 @@ def market_credentials(self, credentials):
         Args:
             value (dict): A dictionary containing the market credentials.
         """
-        self._market_credentials = value
-
+        self._market_credentials = credentials
 
     @abstractmethod
     def execute_order(self, order):

investing_algorithm_framework/domain/portfolio_provider.py

@@ -8,9 +8,11 @@ class PortfolioProvider(ABC):
 
     Attributes:
         portfolio_id (str): The unique identifier for the portfolio.
-        user_id (str): The unique identifier for the user associated with the portfolio.
+        user_id (str): The unique identifier for the user associated
+            with the portfolio.
         balance (float): The current balance of the portfolio.
-        assets (dict): A dictionary containing the assets in the portfolio and their quantities.
+        assets (dict): A dictionary containing the assets in the
+            portfolio and their quantities.
     """
 
     @abstractmethod

investing_algorithm_framework/domain/utils/__init__.py

@@ -1,6 +1,7 @@
 from .backtesting import pretty_print_backtest, load_backtest_report, \
     pretty_print_backtest_reports_evaluation, load_backtest_reports, \
-    get_backtest_report, pretty_print_positions, pretty_print_trades, pretty_print_orders
+    get_backtest_report, pretty_print_positions, pretty_print_trades, \
+    pretty_print_orders
 from .csv import get_total_amount_of_rows, append_dict_as_row_to_csv, \
     add_column_headers_to_csv, csv_to_list, load_csv_into_dict
 from .random import random_string

investing_algorithm_framework/download_data.py

@@ -1,5 +1,4 @@
 from dateutil import parser
-from datetime import datetime
 from investing_algorithm_framework.services import DataProviderService, \
     ConfigurationService, MarketCredentialService
 from investing_algorithm_framework.infrastructure import \
@@ -8,8 +7,8 @@
 
 def download(
     symbol: str,
-    market = None,
-    date = None,
+    market=None,
+    date=None,
     time_frame: str = None,
     data_type: str = "ohlcv",
     start_date: str = None,
@@ -69,17 +68,3 @@ def download(
         save=save,
         storage_path=storage_path
     )
-
-if __name__ == "__main__":
-    # Example usage
-    data = download(
-        symbol="DOT/EUR",
-        market="bitvavo",
-        data_type="ohlcv",
-        window_size=200,
-        pandas=False,
-        save=False,
-        storage_path="./data",
-        time_frame="1d",
-    )
-    print(len(data))

investing_algorithm_framework/infrastructure/data_providers/__init__.py

@@ -12,6 +12,7 @@ def get_default_data_providers():
         CCXTDataProvider(),
     ]
 
+
 __all__ = [
     'CCXTDataProvider',
     'get_default_data_providers',

investing_algorithm_framework/infrastructure/data_providers/ccxt.py

@@ -13,7 +13,6 @@
 logger = logging.getLogger("investing_algorithm_framework")
 
 
-
 class CCXTDataProvider(DataProvider):
     """
     """
@@ -29,7 +28,7 @@ def __init__(
         symbol=None,
         time_frame=None,
         window_size=None,
-        priority = 1
+        priority=1
     ):
         super().__init__(
             data_type=data_type,
@@ -134,12 +133,13 @@ def has_data(
             symbols = list(symbols.keys())
             return symbol in symbols
 
-        except ccxt.NetworkError as e:
+        except ccxt.NetworkError:
             raise NetworkError(
                 "Network error occurred, make sure you have "
                 "an active internet connection"
             )
-        except Exception as e:
+
+        except Exception:
             return False
 
     def get_data(
@@ -161,15 +161,17 @@ def get_data(
 
         if market is None:
             raise OperationalException(
-                "Market is not set. Please set the market before calling get_data."
+                "Market is not set. Please set the market "
+                "before calling get_data."
             )
 
         if symbol is None:
             symbol = self.symbol
 
         if symbol is None:
             raise OperationalException(
-                "Symbol is not set. Please set the symbol before calling get_data."
+                "Symbol is not set. Please set the symbol "
+                "before calling get_data."
             )
 
         if data_type is None:
@@ -195,7 +197,6 @@ def get_data(
             if end_date is None:
                 end_date = datetime.now(tz=timezone.utc)
 
-
             if start_date is None:
 
                 if date is not None:
@@ -309,4 +310,4 @@ def get_ohlcv(
 
     def create_start_date(self, end_date, time_frame, window_size):
         minutes = TimeFrame.from_value(time_frame).amount_of_minutes
-        return end_date - timedelta(minutes=window_size * minutes)
+        return end_date - timedelta(minutes=window_size * minutes)

investing_algorithm_framework/services/market_data_source_service/data_provider_service.py

@@ -46,9 +46,9 @@ def find_data_provider(
                     time_frame=time_frame,
                 ):
                     matching_providers.append(provider)
-        except NetworkError as e:
+        except NetworkError:
             number_of_network_errors += 1
-        except Exception as e:
+        except Exception:
             pass
 
         if len(matching_providers) == 0 and number_of_network_errors > 0:
@@ -61,6 +61,7 @@ def find_data_provider(
         matching_providers.sort(key=lambda p: p.priority)
         return matching_providers[0] if matching_providers else None
 
+
 class DataProviderService:
     data_providers: List[DataProvider] = []
     default_data_providers: List[DataProvider] = [
@@ -86,42 +87,18 @@ def __init__(
         self.configuration_service = configuration_service
         self.market_credentials_service = market_credentials_service
 
-    def _initialize_data_providers(self):
-        """
-        Initialize all data providers.
-
-        This function will call the load_markets and load_symbols
-        methods of all data providers to load the markets and
-        symbols for each data provider. It will also create a
-        DataProviderIndex to index the data providers by symbol
-        and market.
-        """
-        pass
-
-        # if len(self.data_providers) == 0:
-        #     logger.info(
-        #         "No custom data providers found, using default data providers"
-        #     )
-
-        # for provider in self.default_data_providers:
-        #     provider.load_markets()
-        #     provider.load_symbols()
-
-        # Create all indexes
-        # self.data_provider_index = DataProviderIndex(self.data_providers)
-
     def get_data(
         self,
         symbol: str,
-        data_type = None,
+        data_type=None,
         date: datetime = None,
         market: str = None,
         time_frame: str = None,
         start_date: datetime = None,
         end_date: datetime = None,
-        storage_path = None,
-        window_size = None,
-        pandas = False,
+        storage_path=None,
+        window_size=None,
+        pandas=False,
         save: bool = False,
     ):
         """
@@ -188,7 +165,9 @@ def _throw_no_data_provider_exception(self, params):
             f"No data provider found for the given parameters: {params}"
         )
 
-    def add_data_provider(self, data_provider: DataProvider, priority: int = 0):
+    def add_data_provider(
+        self, data_provider: DataProvider, priority: int = 0
+    ):
         """
         Add a data provider to the service.
 
@@ -197,4 +176,4 @@ def add_data_provider(self, data_provider: DataProvider, priority: int = 0):
             priority (int): The priority of the data provider.
         """
         self.data_providers.append(data_provider)
-        self.data_providers.sort(key=lambda x: x.priority, reverse=True)
+        self.data_providers.sort(key=lambda x: x.priority, reverse=True)