Skip to content

Fix stop losses bug when using 100% of the portfolio value #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 27, 2025

Conversation

MDUYN
Copy link
Collaborator

@MDUYN MDUYN commented Apr 27, 2025

Fix stop loss/take profix 100% bug

Description

This fix removes the bug when there are both stop losses and take profits registered with alteast one set to 100% trade size.
This previously created a negative trade, which can't be the case.

Type of Change

  • Bugfix
  • New feature
  • Documentation update
  • Refactor/optimization

Checklist

  • Code is formatted with black or a similar linter.
  • Tests have been added or updated.
  • Documentation has been updated (if needed).

Additional Notes

Include any additional notes or context here.

@MDUYN MDUYN merged commit 369c796 into main Apr 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant