feat: Update to Next.js 14

Author: codinsonn

apps/next/app/ClientRootLayout.tsx

@@ -26,7 +26,7 @@ setPublicEnvVars({
 
 const NextClientRootLayout = (props: { children: React.ReactNode }) => {
   // Props
-  const { children } = props
+  const { children } = props // FIXME: Why is children null on hydration??
 
   // -- Fonts --
 

apps/next/app/layout.tsx

@@ -4,6 +4,8 @@ import NextClientRootLayout from './ClientRootLayout'
 
 /* --- <NextRootLayout/> ----------------------------------------------------------------------- */
 
+// FIXME: Why is children null when passing it to NextClientRootLayout?
+
 const NextRootLayout = ({ children }: { children: React.ReactNode }) => (
   <Document>
     <NextClientRootLayout>{children}</NextClientRootLayout>

apps/next/next.config.js

@@ -69,7 +69,14 @@ const nextConfig = {
         ignoreBuildErrors: true,
     },
     images: {
-        domains: ['i3.ytimg.com'],
+        remotePatterns: [
+            {
+                protocol: 'https',
+                hostname: 'i3.ytimg.com',
+                // port: '',
+                // pathname: '/account123/**',
+            },
+        ],
     },
     webpack: (config, { isServer }) => {
         // -i- Run aetherspace automation scripts in DEV mode

apps/next/package.json

@@ -19,11 +19,11 @@
         "app": "*",
         "encoding": "^0.1.13",
         "expo-asset-web": "npm:expo-asset@8.7.0",
-        "next": "13.4.8",
+        "next": "14.0.0",
         "next-fonts": "^1.5.1",
         "next-images": "^1.8.5",
         "next-pwa": "^5.6.0",
-        "next-transpile-modules": "^10.0.0",
+        "next-transpile-modules": "^10.0.1",
         "raf": "^3.4.1",
         "registries": "*",
         "setimmediate": "^1.0.5",

features/app-core/hooks/useLoadFonts.ts

@@ -28,8 +28,6 @@ const useLoadFonts = () => {
     Roboto700: Roboto_700Bold,
     Roboto800: Roboto_900Black, // Fallback
     Roboto900: Roboto_900Black,
-    // - Icon Fonts -
-    AntDesign: require('@expo/vector-icons/build/vendor/react-native-vector-icons/Fonts/AntDesign.ttf'),
   }
 
   const [googleFontsLoaded, googleFontsError] = useFonts(fontsToLoad)

features/cv-page/icons/registry.tsx

@@ -11,7 +11,7 @@
     "packages/*"
   ],
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=18.17.0"
   },
   "browser": {
     "fs": false,

package.json

@@ -6,8 +6,6 @@ There’s many different ways to use icons and icon sets in Aetherspace. Here’
 → SSR support, fast & easy, no layout shift on web, limited options
 - Custom SVG components using `react-native-svg`  
 → SSR support, can [convert from .svg file](https://transform.tools/svg-to-react-native), but could be more time-consuming
-- Third party iconfont libraries, such as `@expo/vector-icons`  
-→ Fast & easy, needs icon font preloaded, layout shift on web, locked out of SWC
 - Image icons through src urls  
 → Straight forward, easy, not super optimised, fixed colors, layout shift on web  
 
@@ -155,99 +153,6 @@ Downsides of this strategy:
 - Time consuming: Requires some copy-pasting between transform tools and your code
 - Therefore, even if it’s most reliable and configurable, also not very fast or scalable
 
-## Using `@expo/vector-icons`
-
-[Expo Docs: @expo/vector-icons](https://docs.expo.dev/guides/icons/)
-
-> Check which iconset you want to use and how to use them on [https://icons.expo.fyi/](https://icons.expo.fyi/)
-
-Benefits of using this strategy:
-
-- Fast, choose icons from existing third party icon providers
-- Most @expo/vector-icons are also compatible with the web
-
-Downsides of using icon fonts under the hood:
-
-- You’ll need to preload your icon font somehow, easy on mobile but harder on web
-- Loading flicker, meaning you might not see the icon immediately if the icon font isn’t loaded yet
-- Cannot use Next.js’s SWC compiler when using any of the @expo/vector-icons (no loader for importing .ttf files)
-
-Example usage:
-
-```tsx
-import { AntDesign } from '@expo/vector-icons'
-
-<AntDesign
-  name="caretup"
-  size={24}
-  color="#333333"
-/>
-```
-
-Example preloading of icon font on mobile:
-
-`/features/app-core/hooks/useLoadFonts.ts`
-
-```tsx
-'use client'
-import { useFonts } from 'expo-font'
-import { /* Google Fonts */ } from '@expo-google-fonts/roboto'
-
-/* --- useLoadFonts() -------------------------------------------------------------------------- */
-
-const useLoadFonts = () => {
-  const fontsToLoad = {
-    // - Google Fonts -
-    /* ... */
-    // - Icon Fonts -
-    AntDesign: require('@expo/vector-icons/build/vendor/react-native-vector-icons/Fonts/AntDesign.ttf'),
-    // -!- important: always double check this path (^) for your icon fonts
-  }
-
-  const [fontsLoaded, fontsError] = useFonts(fontsToLoad)
-
-  if (fontsError) console.error('fontErrors:', fontsLoaded)
-
-  // -- Return --
-
-  return fontsLoaded // <- Keep splash screen open until this is true
-}
-
-/* --- Exports --------------------------------------------------------------------------------- */
-
-export default useLoadFonts
-```
-
-Example usage with `<AetherIcon/>`
-
-`/packages/{workspace-folder}/icons/registry.tsx`
-
-```tsx
-import React from 'react'
-import { registerIconRenderer } from 'aetherspace/utils'
-import { AntDesign } from '@expo/vector-icons'
-import { ComponentProps } from 'react'
-
-/** --- iconRegistry --------------------------------------------------------------------------- */
-/** -i- Register any icons by preferred AetherIcon "name" key */
-export const iconRegistry = {
-  // Register any icons from e.g. AntDesign you want by
-  // registering them by strings 👇 array (readonly) + render function
-  ...registerIconRenderer(['caretup'] as const, ({ name, size, fill, ...restIconProps }) => (
-    <AntDesign
-      name={name as ComponentProps<typeof AntDesign>['name']}
-      size={size}
-      color={fill}
-      {...restIconProps}
-    />
-  )),
-} as const // <-- Readonly is important here for accurate type hints
-```
-
-```tsx
-<AetherIcon name="caretup" size={24} fill="#333333" />
-```
-
 ## Using `AetherImage` with `.svg` files
 
 > Using `AetherImage` with `.svg` files might be the most bundle size friendly way of using SVGs in your app. Since it will always result in only using the SVGs that you actually use in your app.

packages/@aetherspace/components/AetherIcon/README.md

@@ -1,25 +1,19 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-var react_1 = require("react");
-var addons_1 = require("@storybook/addons");
+const react_1 = require("react");
+const addons_1 = require("@storybook/addons");
 /* --- GraphQL Storybook Plugin ---------------------------------------------------------------- */
-addons_1.addons.register('/graphql', function () {
+addons_1.addons.register('/graphql', () => {
     addons_1.addons.add('graphql-playground/tab', {
         type: addons_1.types.TAB,
         title: 'GraphQL',
-        route: function (_a) {
-            var storyId = _a.storyId;
-            return "/graphql/".concat(storyId);
-        },
-        match: function (_a) {
-            var viewMode = _a.viewMode;
-            return viewMode === 'graphql';
-        },
-        render: function () {
-            var graphqlUrl = 'http://localhost:3000/api/graphql';
-            var isDev = process.env.NODE_ENV === 'development';
+        route: ({ storyId }) => `/graphql/${storyId}`,
+        match: ({ viewMode }) => viewMode === 'graphql',
+        render: () => {
+            let graphqlUrl = 'http://localhost:3000/api/graphql';
+            const isDev = process.env.NODE_ENV === 'development';
             if (!isDev)
-                graphqlUrl = "".concat(process.env.STORYBOOK_BACKEND_URL, "/api/graphql");
+                graphqlUrl = `${process.env.STORYBOOK_BACKEND_URL}/api/graphql`;
             return (0, react_1.createElement)('iframe', {
                 style: { width: '100%', height: '100%' },
                 src: graphqlUrl,

packages/@aetherspace/docs/addons/gqlPlaygroundAddon.js

@@ -7,7 +7,6 @@ module.exports = [
     // - Modules -
     'twrnc',
     '@react-native/assets-registry',
-    '@expo/vector-icons',
     // - Packages & Features -
     ...transpiledWorkspaces,
 ]