Skip to content

Carry system settings to new workspace #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2020

Conversation

andrewrfreed
Copy link
Collaborator

Solves #113 . Thanks to @sueschm for the investigation!

DCO 1.1 Signed-off-by: Andrew R. Freed afreed@us.ibm.com

Copy link
Collaborator

@victorpovar victorpovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addresses the enhancement request. Upon further testing, the additional parts of the json we may want to capture for future enhancements are related to the "webhooks" section. Probably not urgent, but something for a future enhancement.

"webhooks": [
{
"url": "http://XXXXXXXX",
"name": "main_webhook",
"headers": [
{
"name": "XXXXXX",
"value": "XXXXXX"
},
{
"name": "Accept",
"value": "application/json"
}
]
}
],

@andrewrfreed
Copy link
Collaborator Author

Thanks for the note Victor, I have opened a new issue to track. #177

@andrewrfreed andrewrfreed merged commit b7ca95f into master Nov 30, 2020
@andrewrfreed andrewrfreed deleted the 113_carry_system_settings branch November 30, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants