Skip to content

[TPC-H] Adjust default cluster sizes #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2024
Merged

[TPC-H] Adjust default cluster sizes #1370

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21f1e55
Adjust default cluster sizes
hendrikmakait Feb 9, 2024
9c11eba
Merge branch 'main' into adjust-default-clusters-for-tpch
hendrikmakait Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions tests/tpch/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ def cluster_spec(scale):
if scale == 10:
return {
"worker_vm_types": ["m6i.large"],
"n_workers": 16,
"n_workers": 8,
**everywhere,
}
elif scale == 100:
Expand All @@ -158,15 +158,15 @@ def cluster_spec(scale):
}
elif scale == 1000:
return {
"worker_vm_types": ["m6i.large"],
"worker_vm_types": ["m6i.xlarge"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noted that pyspark query 21 would always fail with this setup, but will succeed with m6i.2xlarge.
Maybe that's okay though? If we succeed with this and pyspark mostly succeeds w/ other queries except one, then too bad for them(?).

"n_workers": 32,
**everywhere,
}
elif scale == 10000:
return {
"worker_vm_types": ["m6i.2xlarge"],
"n_workers": 64,
"worker_disk_size": 100,
"worker_vm_types": ["m6i.xlarge"],
"n_workers": 32,
"worker_disk_size": 200,
**everywhere,
}

Expand Down Expand Up @@ -294,15 +294,15 @@ def fs(local):
def machine_spec(scale):
if scale == 10:
return {
"vm_type": "m6i.8xlarge",
"vm_type": "m6i.4xlarge",
}
elif scale == 100:
return {
"vm_type": "m6i.8xlarge",
}
elif scale == 1000:
return {
"vm_type": "m6i.16xlarge",
"vm_type": "m6i.32xlarge",
}
elif scale == 10000:
return {
Expand Down