Merge pull request #293 from coliff/dev/coliff/dep-package-config-update

Tighten linters, update Node, and tweak JS

Author: coliff

.eslintrc.json

@@ -1,12 +1,24 @@
 {
   "root": true,
   "env": {
+    "browser": true,
     "es6": true,
     "node": true
   },
   "extends": ["eslint:recommended"],
   "ignorePatterns": ["*.min.*"],
   "rules": {
-    "no-undef": "off"
+    "curly": "error",
+    "dot-notation": "error",
+    "eqeqeq": "error",
+    "no-implicit-coercion": "error",
+    "no-return-assign": "error",
+    "no-shadow": "error",
+    "no-unneeded-ternary": "error",
+    "no-undef": "error",
+    "no-var": "error",
+    "prefer-const": "error",
+    "radix": "error",
+    "yoda": "error"
   }
 }

.github/workflows/super-linter.yml

@@ -27,6 +27,9 @@ jobs:
           fetch-depth: 0
           persist-credentials: false
 
+      - name: Install Dependencies
+        run: npm install
+
       - name: Lint Code Base
         uses: super-linter/super-linter/slim@9e863354e3ff62e0727d37183162c4a88873df41 # v8.6.0
         env:
@@ -40,7 +43,6 @@ jobs:
           VALIDATE_BIOME_FORMAT: false
           VALIDATE_BIOME_LINT: false
           VALIDATE_CHECKOV: false
-          VALIDATE_CSS: false
           VALIDATE_EDITORCONFIG: false
           VALIDATE_GIT_COMMITLINT: false
           VALIDATE_GITLEAKS: false

.htmlhintrc

@@ -2,7 +2,9 @@
   "alt-require": true,
   "attr-lowercase": true,
   "attr-no-duplication": true,
+  "attr-no-unnecessary-whitespace": true,
   "attr-value-double-quotes": true,
+  "attr-value-no-duplication": true,
   "attr-whitespace": true,
   "button-type-require": true,
   "doctype-first": true,
@@ -11,7 +13,9 @@
   "frame-title-require": true,
   "h1-require": true,
   "html-lang-require": true,
+  "id-class-ad-disabled": true,
   "id-unique": true,
+  "input-requires-label": true,
   "link-rel-canonical-require": false,
   "main-require": true,
   "meta-charset-require": true,
@@ -21,6 +25,7 @@
   "src-not-empty": true,
   "tag-no-obsolete": true,
   "tag-pair": true,
+  "tags-check": false,
   "tagname-lowercase": true,
   "title-require": true
 }

.nvmrc

@@ -1 +1 @@
-v20
+v22.22.2

js/show-password-toggle.js

@@ -4,7 +4,7 @@
  * Licensed under MIT (https://github.com/coliff/bootstrap-show-password-toggle/blob/main/LICENSE)
  */
 
-var ShowPasswordToggle = document.querySelector("[type='password']");
+const ShowPasswordToggle = document.querySelector("[type='password']");
 ShowPasswordToggle.onclick = function () {
   document.querySelector("[type='password']").classList.add("input-password");
   document.getElementById("toggle-password").classList.remove("d-none");

js/show-password-toggle.min.js

@@ -34,10 +34,11 @@
     "css": "npm-run-all css-lint css-compile css-minify",
     "css-compile": "sass --style expanded --source-map --embed-sources scss:css",
     "css-lint": "stylelint \"scss/*.scss\" --fix -f verbose",
-    "html-lint": "htmlhint \"tests/bootstrap5-sign-in/*.html\"",
+    "html-lint": "htmlhint \"tests/**/*.html\"",
     "css-minify": "cleancss -O1 --format breakWith=lf --output css/show-password-toggle.min.css css/show-password-toggle.css",
     "js-lint": "eslint js/show-password-toggle.js --fix",
     "js-minify": "terser --ecma 5 --keep-classnames --keep-fnames --output js/show-password-toggle.min.js -- js/show-password-toggle.js",
+    "lint": "npm-run-all css-lint js-lint html-lint",
     "pa11y": "npx pa11y https://coliff.github.io/bootstrap-show-password-toggle/tests/bootstrap5-sign-in/",
     "prettier": "npx prettier@3 --write \"**/*.{css,html,js,json,scss,yml}\"",
     "serve": "npx http-server -o /tests/bootstrap5-sign-in/ -p 8080 -c-1",
@@ -54,6 +55,6 @@
     "terser": "5.46.1"
   },
   "volta": {
-    "node": "22.22.1"
+    "node": "22.22.2"
   }
 }

package.json

@@ -22,8 +22,6 @@
         margin-top: 17%;
       }
     </style>
-    <!-- Bootstrap 5 IE11 Polyfills -->
-    <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/bootstrap-ie11@5/css/bootstrap-ie11.min.css" media="all and (-ms-high-contrast: active), (-ms-high-contrast: none)" />
   </head>
 
   <body class="text-center bg-secondary-subtle h-100 mt-5">