Fix CI (mongodb#5990)

Co-authored-by: Johnny Shields <27655+johnnyshields@users.noreply.github.com>
Co-authored-by: Jamis Buck <jamis.buck@mongodb.com>
Co-authored-by: Dmitry Rybakov <dmitry@rybakov.eu>

Author: 4 people

gemfiles/standard.rb

@@ -1,8 +1,9 @@
+# rubocop:todo all
 def standard_dependencies
   gem 'rake'
 
   group :development do
-    gem 'yard'
+    gem 'yard', '>= 0.9.35'
 
     platform :mri do
       # Debugger for VSCode.
@@ -15,10 +16,15 @@ def standard_dependencies
     # Evergreen configuration generation
     gem 'erubi'
     gem 'tilt'
+    gem 'solargraph', platform: :mri
   end
 
   group :development, :test do
     gem 'rspec', '~> 3.12'
+    gem 'rubocop', '~> 1.45.1'
+    gem 'rubocop-performance', '~> 1.16.0'
+    gem 'rubocop-rake', '~> 0.6.0'
+    gem 'rubocop-rspec', '~> 2.18.1'
 
     platform :mri do
       gem 'byebug'
@@ -41,4 +47,8 @@ def standard_dependencies
       gem 'timeout-interrupt'
     end
   end
+
+  if ENV['FLE'] == 'helper'
+    gem 'libmongocrypt-helper', '~> 1.8.0'
+  end
 end

spec/shared

@@ -2,27 +2,30 @@
 
 module Mongoid
   module Expectations
-
-    def connection_class
-      if defined?(Mongo::Server::ConnectionBase)
-        Mongo::Server::ConnectionBase
-      else
-        # Pre-2.8 drivers
-        Mongo::Server::Connection
+    # Previously this method used RSpec::Mocks with .exactly.times(n).and_call_original,
+    # which stopped working reliably in Ruby 3.3. Now we directly wrap the target method.
+    def expect_query(number)
+      if %i[ sharded load-balanced ].include?(ClusterConfig.instance.topology) && number > 0
+        skip 'This spec requires replica set or standalone topology'
       end
-    end
 
-    def expect_query(number)
-      rv = nil
-      RSpec::Mocks.with_temporary_scope do
-        if number > 0
-          expect_any_instance_of(connection_class).to receive(:command_started).exactly(number).times.and_call_original
-        else
-          expect_any_instance_of(connection_class).not_to receive(:command_started)
+      klass = Mongo::Server::ConnectionBase
+      original_method = klass.instance_method(:command_started)
+      query_count = 0
+
+      begin
+        klass.define_method(:command_started) do |*args, **kwargs|
+          query_count += 1
+          original_method.bind_call(self, *args, **kwargs)
         end
-        rv = yield
+
+        result = yield
+        expect(query_count).to eq(number)
+        result
+      ensure
+        klass.remove_method(:command_started)
+        klass.define_method(:command_started, original_method)
       end
-      rv
     end
 
     def expect_no_queries(&block)