Skip to content

Commit fc913ed

Browse files
authored
Merge pull request #2 from comet-ml/comet-sdk-3.1.1-compat
Fix error handling for non-existing project
2 parents 2841c62 + 756678d commit fc913ed

File tree

1 file changed

+8
-13
lines changed

1 file changed

+8
-13
lines changed

comet_for_mlflow/comet_for_mlflow.py

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
from comet_ml.comet import format_url
3939
from comet_ml.config import get_api_key, get_config
4040
from comet_ml.connection import Reporting, get_comet_api_client, url_join
41-
from comet_ml.exceptions import CometRestApiException, NotFound
41+
from comet_ml.exceptions import CometRestApiException
4242
from comet_ml.offline import upload_single_offline_experiment
4343
from mlflow.entities.run_tag import RunTag
4444
from mlflow.entities.view_type import ViewType
@@ -528,17 +528,15 @@ def create_and_save_comet_project(self, exp, tag_name):
528528
project_name = get_comet_project_name(self.store, exp.name)
529529

530530
# Check if the project exists already
531-
try:
532-
project = self.api_client.get_project(self.workspace, project_name)
533-
if not project:
534-
raise NotFound("POST", {})
535-
project_id = project["projectId"]
536-
except NotFound:
531+
project = self.api_client.get_project(self.workspace, project_name)
532+
if not project:
537533
project = self.api_client.create_project(
538534
self.workspace, project_name, public=False
539535
)
540536

541537
project_id = project["projectId"]
538+
else:
539+
project_id = project["projectId"]
542540

543541
# Save the project id to the experiment tags
544542
self.store.set_experiment_tag(exp.experiment_id, RunTag(tag_name, project_id))
@@ -555,15 +553,12 @@ def get_or_create_comet_project(self, exp):
555553
project_id = exp.tags[tag_name]
556554

557555
# Check if the project exists
558-
try:
559-
project = self.api_client.get_project_by_id(project_id)
560-
if not project:
561-
raise NotFound("POST", {})
562-
return project["projectName"]
563-
except (NotFound):
556+
project = self.api_client.get_project_by_id(project_id)
557+
if not project:
564558
# A previous project ID has been saved but don't exists anymore (at
565559
# least in this environment), recreate it
566560
return self.create_and_save_comet_project(exp, tag_name)
561+
return project["projectName"]
567562
else:
568563
return self.create_and_save_comet_project(exp, tag_name)
569564

0 commit comments

Comments
 (0)