Skip to content

feat: Support ComfyUI-Manager for pip version #7555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

feat: Support ComfyUI-Manager for pip version #7555

wants to merge 14 commits into from
+21 −0

Conversation

ltdrdata
Copy link
Collaborator

@ltdrdata ltdrdata commented Apr 9, 2025 •
edited
Loading

Manual setup required, yet.

Comfy-Org/ComfyUI-Manager#1737

@christian-byrne
Copy link
Contributor

christian-byrne commented Apr 10, 2025 •
edited
Loading

Can we also ensure the comfyui manager custom node is not imported, except if --disable-manager?

And add to requirements.txt?

@christian-byrne christian-byrne mentioned this pull request Apr 10, 2025
Closed
9 tasks
@ltdrdata ltdrdata mentioned this pull request Apr 10, 2025
Draft
ltdrdata added 2 commits April 12, 2025 19:08
@ltdrdata
Merge branch 'master' into dr-support-pip-cm
311f64a
@ltdrdata
add comfyui_manager to requirements.txt
cc975e5 
It's still in the development stage, so the version is not pinned yet.
@ltdrdata ltdrdata mentioned this pull request Apr 12, 2025
Draft
19 tasks
ltdrdata added 2 commits April 12, 2025 21:53
@ltdrdata
fixed: Ensure that comfyui_manager's prestartup always runs, even w…
418eaed 
…hen `--disable-all-custom-nodes` is used.

feat: Disable specific custom nodes according to the policy of `comfyui_manager`.
@ltdrdata
add --enable-manager-legacy-ui
94f61c6
@christian-byrne
Copy link
Contributor

I think if --disable-manager is set, we should not import the package at all.

@ltdrdata
Copy link
Collaborator Author

My intention was that --disable-manager should only disable the Manager web service, while keeping other auxiliary features intact.
This includes components like the security scanner, and also allows the Manager to be used as a library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoland68 yoland68 Awaiting requested review from yoland68 yoland68 will be requested when the pull request is marked ready for review yoland68 is a code owner

@robinjhuang robinjhuang Awaiting requested review from robinjhuang robinjhuang will be requested when the pull request is marked ready for review robinjhuang is a code owner

@huchenlei huchenlei Awaiting requested review from huchenlei huchenlei will be requested when the pull request is marked ready for review huchenlei is a code owner

@webfiltered webfiltered Awaiting requested review from webfiltered webfiltered will be requested when the pull request is marked ready for review webfiltered is a code owner

@pythongosssss pythongosssss Awaiting requested review from pythongosssss pythongosssss will be requested when the pull request is marked ready for review pythongosssss is a code owner

@Kosinkadink Kosinkadink Awaiting requested review from Kosinkadink Kosinkadink will be requested when the pull request is marked ready for review Kosinkadink is a code owner

@comfyanonymous comfyanonymous Awaiting requested review from comfyanonymous comfyanonymous will be requested when the pull request is marked ready for review comfyanonymous is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ltdrdata @christian-byrne