Skip to content

Add dynatrace monitoring module #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

lojzatran
Copy link
Contributor

@lojzatran lojzatran commented Apr 15, 2024

I added same metrics as in other monitoring modules. Example app for this: #623

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 3.60360% with 107 lines in your changes are missing coverage. Please review.

Project coverage is 10.59%. Comparing base (29dd4b3) to head (fe8e20e).

Files Patch % Lines
...itoring/dynatrace/DynatraceResponseSerializer.java 0.00% 61 Missing ⚠️
...toring/dynatrace/DynatraceTelemetryMiddleware.java 0.00% 45 Missing ⚠️
...mercetools/monitoring/dynatrace/DynatraceInfo.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #622      +/-   ##
============================================
- Coverage     10.60%   10.59%   -0.02%     
- Complexity     1842     1843       +1     
============================================
  Files          6220     6224       +4     
  Lines         59405    59516     +111     
  Branches        265      267       +2     
============================================
+ Hits           6299     6303       +4     
- Misses        52941    53048     +107     
  Partials        165      165              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lojzatran lojzatran marked this pull request as ready for review April 15, 2024 13:36
@lojzatran lojzatran requested a review from a team as a code owner April 15, 2024 13:36
@lojzatran lojzatran requested a review from jenschude April 15, 2024 20:22
@lojzatran
Copy link
Contributor Author

We decided not to add dynatrace module for now.

Reason: it would add too much overhead as it uses HTTP to create new metrics. This would significantly slow down every request to commercetools. The other way for now for dynatrace is to use opentelemetry.

@lojzatran lojzatran closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant