-
Notifications
You must be signed in to change notification settings - Fork 16
Newrelic add metrics #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newrelic add metrics #630
Conversation
…rcetools-sdk-java-v2 into newrelic_add_metrics
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #630 +/- ##
============================================
+ Coverage 10.60% 10.68% +0.07%
- Complexity 1842 1853 +11
============================================
Files 6220 6230 +10
Lines 59405 59572 +167
Branches 265 270 +5
============================================
+ Hits 6299 6364 +65
- Misses 52941 53043 +102
Partials 165 165 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change only
I added the custom metrics. The metric naming is according to the rules from NewRelic: https://docs.newrelic.com/docs/apm/agents/manage-apm-agents/agent-data/collect-custom-metrics/.
I picked metric timesliced data: https://docs.newrelic.com/docs/data-apis/understand-data/new-relic-data-types/#metrics-new-relic. It is 4x faster than using Metric API as it uses APM to submit metrics. On the other hand it does not support dimensions and the other suggested workarounds are not ideal (https://stackoverflow.com/questions/68366017/recording-custom-dimensional-metrics-in-new-relic).
I also updated the docs: https://github.com/commercetools/commercetools-docs/pull/4963