Skip to content

Newrelic add metrics #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 3, 2024
Merged

Newrelic add metrics #630

merged 9 commits into from
May 3, 2024

Conversation

lojzatran
Copy link
Contributor

@lojzatran lojzatran commented Apr 29, 2024

I added the custom metrics. The metric naming is according to the rules from NewRelic: https://docs.newrelic.com/docs/apm/agents/manage-apm-agents/agent-data/collect-custom-metrics/.

I picked metric timesliced data: https://docs.newrelic.com/docs/data-apis/understand-data/new-relic-data-types/#metrics-new-relic. It is 4x faster than using Metric API as it uses APM to submit metrics. On the other hand it does not support dimensions and the other suggested workarounds are not ideal (https://stackoverflow.com/questions/68366017/recording-custom-dimensional-metrics-in-new-relic).

I also updated the docs: https://github.com/commercetools/commercetools-docs/pull/4963

@lojzatran lojzatran marked this pull request as ready for review April 29, 2024 13:14
@lojzatran lojzatran requested a review from a team as a code owner April 29, 2024 13:14
@lojzatran lojzatran requested a review from jenschude April 29, 2024 13:14
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 10.68%. Comparing base (29dd4b3) to head (5fd5de3).
Report is 31 commits behind head on main.

Files Patch % Lines
...onitoring/newrelic/NewrelicResponseSerializer.java 0.00% 23 Missing ⚠️
...nitoring/newrelic/NewRelicTelemetryMiddleware.java 0.00% 6 Missing ⚠️
...ommercetools/monitoring/newrelic/NewrelicInfo.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #630      +/-   ##
============================================
+ Coverage     10.60%   10.68%   +0.07%     
- Complexity     1842     1853      +11     
============================================
  Files          6220     6230      +10     
  Lines         59405    59572     +167     
  Branches        265      270       +5     
============================================
+ Hits           6299     6364      +65     
- Misses        52941    53043     +102     
  Partials        165      165              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jenschude jenschude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change only

@jenschude jenschude merged commit 763d13c into main May 3, 2024
11 of 12 checks passed
@jenschude jenschude deleted the newrelic_add_metrics branch May 3, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants