Skip to content

Update generated SDKs #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 2 additions & 55 deletions changes.md
Original file line number Diff line number Diff line change
@@ -1,61 +1,8 @@
**Api changes**

<details>
<summary>Changed Type(s)</summary>
<summary>Changed Property(s)</summary>

- :warning: changed type `DeliveryPayload` from type `object` to `SubscriptionNotification`
</details>


<details>
<summary>Added Type(s)</summary>

- added type `BusinessUnitSetUnitTypeAction`
- added type `BaseEvent`
- added type `Event`
- added type `ImportContainerCreatedEvent`
- added type `ImportContainerCreatedEventData`
- added type `ImportContainerDeletedEvent`
- added type `ImportContainerDeletedEventData`
- added type `ImportOperationRejectedEvent`
- added type `ImportOperationRejectedEventData`
- added type `ImportUnresolvedEvent`
- added type `ImportUnresolvedEventData`
- added type `ImportValidationFailedEvent`
- added type `ImportValidationFailedEventData`
- added type `ImportWaitForMasterVariantEvent`
- added type `ImportWaitForMasterVariantEventData`
- added type `BusinessUnitTopLevelUnitSetMessage`
- added type `BusinessUnitTypeSetMessage`
- added type `BusinessUnitTopLevelUnitSetMessagePayload`
- added type `BusinessUnitTypeSetMessagePayload`
- added type `EventDeliveryPayload`
- added type `EventSubscription`
- added type `EventSubscriptionResourceTypeId`
- added type `EventType`
- added type `SubscriptionNotification`
- added type `SubscriptionSetEventsAction`
</details>


<details>
<summary>Required Property(s)</summary>

- changed property `facets` of type `ProductProjectionPagedSearchResponse` to be optional
</details>


<details>
<summary>Added Property(s)</summary>

- added property `events` to type `Subscription`
- added property `events` to type `SubscriptionDraft`
</details>


<details>
<summary>Removed QueryParameter(s)</summary>

- :warning: removed query parameter `withTotal` from method `get /{projectKey}/product-projections/search`
- :warning: changed property `actions` of type `MyBusinessUnitUpdate` from type `BusinessUnitUpdateAction[]` to `MyBusinessUnitUpdateAction[]`
</details>

Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

import javax.annotation.Nullable;

import com.commercetools.api.models.business_unit.BusinessUnitUpdateAction;
import com.fasterxml.jackson.annotation.*;
import com.fasterxml.jackson.databind.annotation.*;

Expand Down Expand Up @@ -50,7 +49,7 @@ public interface MyBusinessUnitUpdate {
@NotNull
@Valid
@JsonProperty("actions")
public List<BusinessUnitUpdateAction> getActions();
public List<MyBusinessUnitUpdateAction> getActions();

/**
* <p>Expected version of the BusinessUnit on which the changes should be applied. If the expected version does not match the actual version, a ConcurrentModification error will be returned.</p>
Expand All @@ -65,14 +64,14 @@ public interface MyBusinessUnitUpdate {
*/

@JsonIgnore
public void setActions(final BusinessUnitUpdateAction... actions);
public void setActions(final MyBusinessUnitUpdateAction... actions);

/**
* <p>Update actions to be performed on the BusinessUnit.</p>
* @param actions values to be set
*/

public void setActions(final List<BusinessUnitUpdateAction> actions);
public void setActions(final List<MyBusinessUnitUpdateAction> actions);

/**
* factory method
Expand Down Expand Up @@ -108,7 +107,7 @@ public static MyBusinessUnitUpdate deepCopy(@Nullable final MyBusinessUnitUpdate
instance.setVersion(template.getVersion());
instance.setActions(Optional.ofNullable(template.getActions())
.map(t -> t.stream()
.map(com.commercetools.api.models.business_unit.BusinessUnitUpdateAction::deepCopy)
.map(com.commercetools.api.models.me.MyBusinessUnitUpdateAction::deepCopy)
.collect(Collectors.toList()))
.orElse(null));
return instance;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public class MyBusinessUnitUpdateBuilder implements Builder<MyBusinessUnitUpdate

private Long version;

private java.util.List<com.commercetools.api.models.business_unit.BusinessUnitUpdateAction> actions;
private java.util.List<com.commercetools.api.models.me.MyBusinessUnitUpdateAction> actions;

/**
* <p>Expected version of the BusinessUnit on which the changes should be applied. If the expected version does not match the actual version, a ConcurrentModification error will be returned.</p>
Expand All @@ -45,7 +45,7 @@ public MyBusinessUnitUpdateBuilder version(final Long version) {
*/

public MyBusinessUnitUpdateBuilder actions(
final com.commercetools.api.models.business_unit.BusinessUnitUpdateAction... actions) {
final com.commercetools.api.models.me.MyBusinessUnitUpdateAction... actions) {
this.actions = new ArrayList<>(Arrays.asList(actions));
return this;
}
Expand All @@ -57,7 +57,7 @@ public MyBusinessUnitUpdateBuilder actions(
*/

public MyBusinessUnitUpdateBuilder actions(
final java.util.List<com.commercetools.api.models.business_unit.BusinessUnitUpdateAction> actions) {
final java.util.List<com.commercetools.api.models.me.MyBusinessUnitUpdateAction> actions) {
this.actions = actions;
return this;
}
Expand All @@ -69,7 +69,7 @@ public MyBusinessUnitUpdateBuilder actions(
*/

public MyBusinessUnitUpdateBuilder plusActions(
final com.commercetools.api.models.business_unit.BusinessUnitUpdateAction... actions) {
final com.commercetools.api.models.me.MyBusinessUnitUpdateAction... actions) {
if (this.actions == null) {
this.actions = new ArrayList<>();
}
Expand All @@ -84,12 +84,11 @@ public MyBusinessUnitUpdateBuilder plusActions(
*/

public MyBusinessUnitUpdateBuilder plusActions(
Function<com.commercetools.api.models.business_unit.BusinessUnitUpdateActionBuilder, Builder<? extends com.commercetools.api.models.business_unit.BusinessUnitUpdateAction>> builder) {
Function<com.commercetools.api.models.me.MyBusinessUnitUpdateActionBuilder, Builder<? extends com.commercetools.api.models.me.MyBusinessUnitUpdateAction>> builder) {
if (this.actions == null) {
this.actions = new ArrayList<>();
}
this.actions.add(
builder.apply(com.commercetools.api.models.business_unit.BusinessUnitUpdateActionBuilder.of()).build());
this.actions.add(builder.apply(com.commercetools.api.models.me.MyBusinessUnitUpdateActionBuilder.of()).build());
return this;
}

Expand All @@ -100,10 +99,9 @@ public MyBusinessUnitUpdateBuilder plusActions(
*/

public MyBusinessUnitUpdateBuilder withActions(
Function<com.commercetools.api.models.business_unit.BusinessUnitUpdateActionBuilder, Builder<? extends com.commercetools.api.models.business_unit.BusinessUnitUpdateAction>> builder) {
Function<com.commercetools.api.models.me.MyBusinessUnitUpdateActionBuilder, Builder<? extends com.commercetools.api.models.me.MyBusinessUnitUpdateAction>> builder) {
this.actions = new ArrayList<>();
this.actions.add(
builder.apply(com.commercetools.api.models.business_unit.BusinessUnitUpdateActionBuilder.of()).build());
this.actions.add(builder.apply(com.commercetools.api.models.me.MyBusinessUnitUpdateActionBuilder.of()).build());
return this;
}

Expand All @@ -121,7 +119,7 @@ public Long getVersion() {
* @return actions
*/

public java.util.List<com.commercetools.api.models.business_unit.BusinessUnitUpdateAction> getActions() {
public java.util.List<com.commercetools.api.models.me.MyBusinessUnitUpdateAction> getActions() {
return this.actions;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@ public class MyBusinessUnitUpdateImpl implements MyBusinessUnitUpdate, ModelBase

private Long version;

private java.util.List<com.commercetools.api.models.business_unit.BusinessUnitUpdateAction> actions;
private java.util.List<com.commercetools.api.models.me.MyBusinessUnitUpdateAction> actions;

/**
* create instance with all properties
*/
@JsonCreator
MyBusinessUnitUpdateImpl(@JsonProperty("version") final Long version,
@JsonProperty("actions") final java.util.List<com.commercetools.api.models.business_unit.BusinessUnitUpdateAction> actions) {
@JsonProperty("actions") final java.util.List<com.commercetools.api.models.me.MyBusinessUnitUpdateAction> actions) {
this.version = version;
this.actions = actions;
}
Expand All @@ -54,20 +54,19 @@ public Long getVersion() {
* <p>Update actions to be performed on the BusinessUnit.</p>
*/

public java.util.List<com.commercetools.api.models.business_unit.BusinessUnitUpdateAction> getActions() {
public java.util.List<com.commercetools.api.models.me.MyBusinessUnitUpdateAction> getActions() {
return this.actions;
}

public void setVersion(final Long version) {
this.version = version;
}

public void setActions(final com.commercetools.api.models.business_unit.BusinessUnitUpdateAction... actions) {
public void setActions(final com.commercetools.api.models.me.MyBusinessUnitUpdateAction... actions) {
this.actions = new ArrayList<>(Arrays.asList(actions));
}

public void setActions(
final java.util.List<com.commercetools.api.models.business_unit.BusinessUnitUpdateAction> actions) {
public void setActions(final java.util.List<com.commercetools.api.models.me.MyBusinessUnitUpdateAction> actions) {
this.actions = actions;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,12 @@
}

public CombinationQueryPredicate<MyBusinessUnitUpdateQueryBuilderDsl> actions(
Function<com.commercetools.api.predicates.query.business_unit.BusinessUnitUpdateActionQueryBuilderDsl, CombinationQueryPredicate<com.commercetools.api.predicates.query.business_unit.BusinessUnitUpdateActionQueryBuilderDsl>> fn) {
return new CombinationQueryPredicate<>(ContainerQueryPredicate.of()
.parent(ConstantQueryPredicate.of().constant("actions"))
.inner(fn.apply(
com.commercetools.api.predicates.query.business_unit.BusinessUnitUpdateActionQueryBuilderDsl.of())),
Function<com.commercetools.api.predicates.query.me.MyBusinessUnitUpdateActionQueryBuilderDsl, CombinationQueryPredicate<com.commercetools.api.predicates.query.me.MyBusinessUnitUpdateActionQueryBuilderDsl>> fn) {
return new CombinationQueryPredicate<>(
ContainerQueryPredicate.of()
.parent(ConstantQueryPredicate.of().constant("actions"))
.inner(fn.apply(
com.commercetools.api.predicates.query.me.MyBusinessUnitUpdateActionQueryBuilderDsl.of())),

Check warning on line 28 in commercetools/commercetools-sdk-java-api/src/main/java-predicates-generated/com/commercetools/api/predicates/query/me/MyBusinessUnitUpdateQueryBuilderDsl.java

View check run for this annotation

Codecov / codecov/patch

commercetools/commercetools-sdk-java-api/src/main/java-predicates-generated/com/commercetools/api/predicates/query/me/MyBusinessUnitUpdateQueryBuilderDsl.java#L24-L28

Added lines #L24 - L28 were not covered by tests
MyBusinessUnitUpdateQueryBuilderDsl::of);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public static Object[][] objectBuilder() {
return new Object[][] { new Object[] { MyBusinessUnitUpdate.builder().version(2L) },
new Object[] { MyBusinessUnitUpdate.builder()
.actions(Collections.singletonList(
new com.commercetools.api.models.business_unit.BusinessUnitUpdateActionImpl())) } };
new com.commercetools.api.models.me.MyBusinessUnitUpdateActionImpl())) } };
}

@Test
Expand All @@ -43,9 +43,9 @@ public void version() {
public void actions() {
MyBusinessUnitUpdate value = MyBusinessUnitUpdate.of();
value.setActions(
Collections.singletonList(new com.commercetools.api.models.business_unit.BusinessUnitUpdateActionImpl()));
Collections.singletonList(new com.commercetools.api.models.me.MyBusinessUnitUpdateActionImpl()));
Assertions.assertThat(value.getActions())
.isEqualTo(Collections
.singletonList(new com.commercetools.api.models.business_unit.BusinessUnitUpdateActionImpl()));
.isEqualTo(
Collections.singletonList(new com.commercetools.api.models.me.MyBusinessUnitUpdateActionImpl()));
}
}
1 change: 1 addition & 0 deletions references.txt
Original file line number Diff line number Diff line change
Expand Up @@ -400,3 +400,4 @@ f2c3348614fec5fe51dfb7adac8744e033626b8b
535ee58310a5fb706c9946aaac9cdc638af996db
f0288f95a5fe33fd2973df3f8290defb15129192
21aedcd93ff144743f0570a5fd0b65af601baa76
761762c7caad45bc86b08db7021a033fff18ba90