Skip to content

Port to Scala 3 #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 151 commits into
base: main
Choose a base branch
from
Open

Port to Scala 3 #651

wants to merge 151 commits into from

Conversation

benko-ct
Copy link
Contributor

@benko-ct benko-ct commented Feb 21, 2025 •
edited
Loading

  • sphere-mongo-core and sphere-json-core are now cross-compiled to scala2/3.
  • We decided to drop scala 2.12 support, if anyone needs that, we can add it back

Some guide for the review:

  • sphere-mongo-core and sphere-json-core now contain scala-3 folders containing scala3 specific code.
    • That's true for both the main and test folders.
    • The test folders contain all tests from the derivation modules + some new tests

peter-empen and others added 30 commits February 21, 2024 19:36
@peter-empen
sphere-mongo-derivation-scala-3
ff4171a
@benko-ct
sphere-mongo-core, sphere-util compiles with both Scala 2 and 3
6aab3f9
@benko-ct
some macro test code
91424e0
@benko-ct
some macro test code2
04a2d75
@benko-ct
some macro test code2
bbabb8a
@benko-ct
some macro test code2
77787a9
@peter-empen
start module and case-class derivation
33049ff
@benko-ct
Autoderivation example with fake bson
4cee24d
@peter-empen
brush up specs
3a120ca
@peter-empen
add .bsp to .gitignore
c888f4f
@peter-empen
scalafmt
cf41666
@peter-empen
fix SBT warnings on target
4da664c
@benko-ct
Port the initial implementation from FakeBson to Actual MongoDB types
a8845d1
@benko-ct
Add MongoKey and MongoEmbedded implementations
396417a
@benko-ct
Add MongoTypeHint and MongoTypeHintField
dbee359
@programaker
ENE-49 Fix infinite loop in derivation
02388ea
@programaker
ENE-49 Add a case with implicit keyword
9298ec3
@peter-empen
add DefaultValuesSpec
8ced215
@programaker
Merge branch 'ENE-49__fix-derivation-infinite-loop' into scala-3
eccd881
@benko-ct
Fix OptionMongoFormatSpec
e4ccd28
@benko-ct
Refactor AnnotationReader macro functions and Remove bad imports.
244dd51
@benko-ct
Move TypedMongoFormat instances to DefaultMongoFormats
cccf067
@programaker
ENE-49 Enums work
e19d164
@programaker
Merge branch 'ENE-49__dev' into scala-3
363d3e7
@benko-ct
Support default values
2f5d1eb
@programaker
ENE-49 Solve merge conflicts
1eb13a2
@programaker
ENE-49 Spec for class with fields with default value
e2b478a
@benko-ct
Add DeriveMongoFormatSpec
aecda6e
@peter-empen
brushing up some code
67943d7
@peter-empen
stat with MongoIgnore
ba48367
benko-ct added 28 commits May 10, 2025 11:09
@benko-ct
Use typeSwitches for the trait case of derivations.
6c12f67
@benko-ct
add enum object support to json-annotationreader too.
9e6a6eb
@benko-ct
Refactor AnnotationReader so common parts can be used by both json an…
5304270 
…d mongo
@benko-ct
renames
a13cd6f
@benko-ct
improve naming
0b585cd
@benko-ct
Fix package structure
941fe88
@benko-ct
Add scala-2 syntax for 'jsonTypeSwitch' methods for scala3
da63668
@benko-ct
test syntax improvements
e479bdf
@benko-ct
Merge branch 'main' into scala-3
de01add 
# Conflicts:
#	json/json-core/src/main/scala/io/sphere/json/FromJSONInstances.scala
#	json/json-core/src/main/scala/io/sphere/json/ToJSONInstances.scala
@benko-ct
Fix merge
37765be
@benko-ct
change names
2b04357
@benko-ct
Syntax changes
cd8b331
@benko-ct
set sbt scala version back
d5ea170
@benko-ct
Refactor JsonTypeSwitch so it can be "merged" with other json instanc…
e903fd4 
…es to allow compatibility with the scala 2 API
@benko-ct
Api backwards compatibility fix
54cb965
@benko-ct
scalafmt
ef94c44
@benko-ct
minor refactor
e33816a
@benko-ct
scalafmt
5583c76
@benko-ct
reenable tests in JsonTypeSwitchSpec
415cc9d
@benko-ct
Merge branch 'main' into scala-3
e60304b 
# Conflicts:
#	json/json-derivation/src/test/scala-2/io/sphere/json/JSONSpec.scala
#	json/json-derivation/src/test/scala/io/sphere/json/generic/DefaultValuesSpec.scala
#	json/json-derivation/src/test/scala/io/sphere/json/generic/JSONKeySpec.scala
#	mongo/mongo-derivation/src/test/scala-2/io/sphere/mongo/SerializationTest.scala
@benko-ct
Move scala2 specific test to their folder
84c3974
@benko-ct
Add tests for subTypeNames in JSON
687c752
@benko-ct
set sbt ThisBuild/scalaversion back to 2.13
e6254cc
@benko-ct
Use Class instead of String for ToFormatters
2cea052
@benko-ct
Use Class instead of String for ToFormatters
17d506e
@benko-ct
Improve naming for ToFormatters/FromFormatters fields
824767f
@benko-ct
Minor refactor
2c04a09
@benko-ct
PlatformFormattedNotification case supported
59d559f
@benko-ct benko-ct changed the title Add sphere-mongo-3 and sphere-json-3 (the scala 3 version of similarly named modules) Port to Scala 3 Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanns yanns yanns left review comments

@sbrunk sbrunk sbrunk left review comments

@programaker programaker programaker approved these changes

+1 more reviewer

@peter-empen peter-empen peter-empen approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@benko-ct @sbrunk @yanns @programaker @peter-empen @ysedira