Change the API to be compatible with the upcoming Scala-3 v… #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersion (details in SCALA-3-MIGRATION-GUIDE.md)
benko-ct
changed the title
peter-empen
approved these changes
May 9, 2025
json/json-derivation/src/main/scala/io/sphere/json/generic/JSONMacros.scala
Show resolved
Hide resolved
json/json-derivation/src/test/scala/io/sphere/json/generic/SubTypeNameSpec.scala
Outdated
Show resolved
Hide resolved
yanns
reviewed
May 9, 2025
| List(SingletonMixed, RecordMixed(1)).foreach { m: Mixed => | ||
| fromJSON[Mixed](toJSON(m)) must equal(Valid(m)) | ||
| } | ||
| } | ||
|
|
||
| it("must provide derived instances for scala.Enumeration") { | ||
| implicit val scalaEnumJSON = deriveJSON[ScalaEnum.Value] | ||
| implicit val scalaEnumJSON: JSON[JSONSpec.ScalaEnum.Value] = jsonEnum(ScalaEnum) |
There was a problem hiding this comment.
We cannot use deriveJSON here?
There was a problem hiding this comment.
Enumerations have a fixed implementation, we don't need to "derive" anything, so I didn't add them to the scala-3 deriveJSON. The code is simpler this way.
If you think it's better to have everything under deriveJSON, I can add it to the scala-3 implementation.
There was a problem hiding this comment.
As we have deriveJSON for enums in scala 2, it would be nice to have the same in scala 3, unless this is too much work. I let you judge here.
programaker
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ersion (details in SCALA-3-MIGRATION-GUIDE.md)