Skip to content

Commit 7c805c1

Browse files
committed
Add support for lower case global constants
1 parent 0b8948e commit 7c805c1

File tree

3 files changed

+5
-16
lines changed

3 files changed

+5
-16
lines changed

auto_typing_final/transform.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ def _make_definition_from_definition_node(node: SgNode) -> Definition:
9292

9393
def _should_skip_global_variable(definition: Definition) -> bool:
9494
return isinstance(definition, EditableAssignmentWithoutAnnotation | EditableAssignmentWithAnnotation) and (
95-
not (definition.left.isupper() and len(definition.left) > 1)
95+
not ((definition.left.isupper() or definition.left.islower()) and len(definition.left) > 1)
9696
or any(one_pattern in definition.right for one_pattern in IGNORED_DEFINITION_PATTERNS)
9797
)
9898

docs/global_vars_enabled.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ DEBUG = True # insert
1414
### Global vs. Local Variable Scope
1515
```python
1616
MY_CONSTANT = 42 # insert
17-
global_var = "hello"
17+
global_var = "hello" # insert
1818

1919
def foo():
2020
local_var = 1 # insert
@@ -48,12 +48,12 @@ FRUIT = Apple | Banana # insert
4848

4949
### Code Examples with Header Improvements
5050

51-
### Unchanged Global Assignment
51+
### Changed lower case assignment
5252
```python
53-
global_var = 42
53+
global_var = 42 # insert
5454
```
5555

56-
### Simple Assignment
56+
### Not lower case assignment
5757
```python
5858
myVar = "hello"
5959
```

tests/test_transform_imports.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -79,17 +79,6 @@ def f():
7979
def f():
8080
a = 1
8181
a = 2
82-
""",
83-
"""
84-
typing = 1
85-
86-
def f():
87-
a = 1
88-
---
89-
typing = 1
90-
91-
def f():
92-
a: typing.Final = 1
9382
""",
9483
],
9584
)

0 commit comments

Comments
 (0)