Skip to content

Commit 4b335a7

Browse files
authored
Merge pull request #39 from sbryngelson/improve
2 parents df7c3d4 + 9ab44d8 commit 4b335a7

File tree

5 files changed

+104
-2
lines changed

5 files changed

+104
-2
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
## Description
2+
3+
<!-- Provide a brief description of the changes you're making -->
4+
5+
## Related Issue(s)
6+
7+
<!-- Link to any related issues (e.g., "Closes #123") -->

.github/workflows/linkchecker.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
name: LinkChecker
2-
3-
on: push
2+
on:
3+
push:
4+
pull_request:
5+
workflow_dispatch:
46

57
jobs:
68
markdown-link-check:

.github/workflows/spelling.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
name: Spell Check
22
on:
33
push:
4+
pull_request:
45
workflow_dispatch:
56

67
jobs:

CONTRIBUTING.md

Lines changed: 85 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,85 @@
1+
# Contributing to the Group Syllabus
2+
3+
Thank you for considering contributing to our research group syllabus!
4+
This document provides guidelines for students and collaborators who want to suggest improvements, fix errors, or add new content.
5+
6+
## Why Contribute?
7+
8+
- **Improve the resource for everyone**: Your experiences and insights can help make this a better resource for current and future students.
9+
- **Develop your skills**: Contributing to documentation is valuable practice for academic and professional work.
10+
- **Build community**: Collaborative maintenance strengthens our research group.
11+
12+
## How to Contribute
13+
14+
### For Small Changes (Typos, Minor Clarifications)
15+
16+
1. **Create an Issue**:
17+
- Go to the [Issues tab](https://github.com/comp-physics/group-docs/issues) and create a new issue
18+
- Use a clear title and describe the change you're suggesting
19+
- Label it appropriately (e.g., "typo", "clarification")
20+
21+
2. **Direct Pull Request**:
22+
- For simple changes, you can directly edit the file on GitHub
23+
- Click the pencil icon on the file you want to edit
24+
- Make your changes and create a pull request with a clear description
25+
26+
### For Larger Contributions (New Content, Major Revisions)
27+
28+
1. **Discuss First**:
29+
- Create an issue describing what you'd like to add or change
30+
- Wait for feedback before investing significant time
31+
32+
2. **Fork and Clone**:
33+
- Fork the repository to your GitHub account
34+
- Clone it to your local machine
35+
- Create a new branch for your changes
36+
37+
3. **Make Changes**:
38+
- Make your changes or additions
39+
- Follow the existing style and formatting
40+
- Add clear commit messages
41+
42+
4. **Submit a Pull Request**:
43+
- Push your changes to your fork
44+
- Create a pull request to the main repository
45+
- Provide a clear description of the changes and why they're valuable
46+
47+
## Content Guidelines
48+
49+
When contributing content, please follow these guidelines:
50+
51+
1. **Be Clear and Concise**: Write in clear, straightforward language.
52+
2. **Be Accurate**: Verify information before submitting.
53+
3. **Follow Existing Structure**: Match the style and organization of existing documents.
54+
4. **Consider All Students**: Remember that this resource serves both PhD and undergraduate students.
55+
5. **Respect Confidentiality**: Don't include sensitive or private information.
56+
57+
## Document Structure
58+
59+
When creating or editing markdown files:
60+
61+
- Use appropriate heading levels (# for title, ## for major sections, ### for subsections)
62+
- Include a table of contents for longer documents
63+
- Use bullet points and numbered lists for clarity
64+
- Link to other relevant documents when appropriate
65+
66+
## Review Process
67+
68+
After submitting a contribution:
69+
70+
1. Spencer will review your submission
71+
2. You may receive feedback or requests for changes
72+
3. Once approved, your contribution will be merged
73+
74+
## Getting Help
75+
76+
If you're unsure about anything related to contributing:
77+
78+
- Contact Spencer directly
79+
- Post a question in the group Slack channel
80+
81+
## Recognition
82+
83+
Contributors will be acknowledged in the repository.
84+
85+
Thank you for helping improve our group documentation!

readme.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,13 @@
3434
* [For figures](templates/paper/figures)
3535
* [For talks](templates/talks)
3636

37+
## Contributing
38+
39+
This repository is designed to be collaborative.
40+
Current and former students are encouraged to contribute improvements, corrections, and additions based on their experiences.
41+
42+
See [CONTRIBUTING.md](CONTRIBUTING.md) for guidelines on how to suggest changes or add content.
43+
3744
## Acknowledgements
3845

3946
Parts of this are borrowed, heavily edited, from the Ph.D. syllabi of [Eric Gilbert](https://docs.google.com/document/d/11D3kHElzS2HQxTwPqcaTnU5HCJ8WGE5brTXI4KLf4dM) and Mor Maaman.

0 commit comments

Comments
 (0)