refactor(views): DistrictView inherits from DetailView

using DetailView for the DistrictView class simplifies the code and
improves readability in the districts/district.html template.

Author: lalver1

pems/districts/templates/districts/district.html

@@ -1,7 +1,7 @@
 {% extends "districts/index.html" %}
 
 {% block headline %}
-    District {{ district_number }} - {{ district.name }}
+    District {{ district.number }} - {{ district.name }}
 {% endblock headline %}
 
 {% block districts-content %}

pems/districts/views.py

@@ -1,4 +1,4 @@
-from django.views.generic import TemplateView
+from django.views.generic import TemplateView, DetailView
 
 from .models import District
 
@@ -17,12 +17,10 @@ class IndexView(DistrictContextMixin, TemplateView):
     template_name = "districts/index.html"
 
 
-class DistrictView(DistrictContextMixin, TemplateView):
+class DistrictView(DistrictContextMixin, DetailView):
+    model = District
+    context_object_name = "district"
     template_name = "districts/district.html"
 
-    def get_context_data(self, **kwargs):
-        context = super().get_context_data(**kwargs)
-        district_number = self.kwargs.get("district")
-        context["district_number"] = district_number
-        context["district"] = context.get("districts").get("all").get(number=district_number)
-        return context
+    def get_object(self):
+        return District.objects.get(number__iexact=self.kwargs["district"])

tests/pytest/pems/districts/test_views.py

@@ -1,5 +1,6 @@
 import pytest
 
+from django.urls import reverse
 from pems.districts import views
 from pems.districts.models import District
 
@@ -23,21 +24,10 @@ def test_template_name(self, view):
         assert view.template_name == "districts/index.html"
 
 
-class TestDistrictView:
-    @pytest.fixture
-    def view(app_request):
-        v = views.DistrictView()
-        v.setup(app_request, district=1)
-
-        return v
+@pytest.mark.django_db
+def test_district_view(client, model_District):
+    url = reverse("districts:district", kwargs={"district": 1})
+    response = client.get(url)
 
-    @pytest.mark.django_db
-    @pytest.mark.usefixtures("model_District")
-    def test_get_context_data(self, view):
-
-        context = view.get_context_data()
-
-        assert context["district_number"] == 1
-
-    def test_template_name(self, view):
-        assert view.template_name == "districts/district.html"
+    assert response.status_code == 200
+    assert response.context["district"] == model_District