feat: implement a page not found (404) error view and template

Author: lalver1

pems/core/views.py

@@ -0,0 +1,10 @@
+from django.views.generic import TemplateView
+
+
+class PageNotFoundView(TemplateView):
+    template_name = "404.html"
+
+    def dispatch(self, request, *args, **kwargs):
+        response = super().dispatch(request, *args, **kwargs)
+        response.status_code = 404
+        return response

pems/settings.py

@@ -52,7 +52,7 @@ def _filter_empty(ls):
 TEMPLATES = [
     {
         "BACKEND": "django.template.backends.django.DjangoTemplates",
-        "DIRS": [],
+        "DIRS": [os.path.join(BASE_DIR, "pems", "templates")],
         "APP_DIRS": True,
         "OPTIONS": {
             "context_processors": [

pems/templates/404.html

@@ -0,0 +1,7 @@
+{% extends "core/base.html" %}
+{% block headline %}
+    Sorry! We can’t find that page.
+{% endblock headline %}
+{% block inner-content %}
+    <p>The page you are looking for might be somewhere else or may not exist anymore.</p>
+{% endblock inner-content %}

pems/urls.py

@@ -1,6 +1,11 @@
 from django.contrib import admin
 from django.urls import include, path
 
+from pems.core.views import PageNotFoundView
+
+
+handler404 = PageNotFoundView.as_view()
+
 urlpatterns = [
     path("", include("pems.core.urls")),
     path("admin/", admin.site.urls),

tests/pytest/pems/core/test_views.py

@@ -0,0 +1,18 @@
+import pytest
+
+from pems.core import views
+
+
+class TestPageNotFoundView:
+    @pytest.fixture
+    def view(app_request):
+        v = views.PageNotFoundView()
+        v.setup(app_request)
+
+        return v
+
+    def test_dispatch(self, view, app_request):
+
+        response = view.dispatch(app_request)
+
+        assert response.status_code == 404