refactor: rename URL parameter and template context for clarity

now the URL parameter is more descriptive, it is the district number,
and the template context refers to the currently selected district

Author: lalver1

pems/districts/templates/districts/district.html

@@ -1,7 +1,7 @@
 {% extends "districts/index.html" %}
 
 {% block headline %}
-    District {{ district.number }} - {{ district.name }}
+    District {{ current_district.number }} - {{ current_district.name }}
 {% endblock headline %}
 
 {% block districts-content %}
@@ -15,7 +15,7 @@ <h2>Chart</h2>
     </div>
     <div class="row">
         <div class="col-lg-4 border">
-            <h2>Details for {{ district.name }}</h2>
+            <h2>Details for {{ current_district.name }}</h2>
         </div>
         <div class="col-lg-8 border">
             <h2>Map</h2>

pems/districts/urls.py

@@ -10,5 +10,5 @@
 urlpatterns = [
     # /districts
     path("", views.IndexView.as_view(), name="index"),
-    path("<int:district>", views.DistrictView.as_view(), name="district"),
+    path("<int:district_number>", views.DistrictView.as_view(), name="district"),
 ]

pems/districts/views.py

@@ -19,8 +19,8 @@ class IndexView(DistrictContextMixin, TemplateView):
 
 class DistrictView(DistrictContextMixin, DetailView):
     model = District
-    context_object_name = "district"
+    context_object_name = "current_district"
     template_name = "districts/district.html"
 
     def get_object(self):
-        return District.objects.get(number__iexact=self.kwargs["district"])
+        return District.objects.get(number__iexact=self.kwargs["district_number"])

tests/pytest/pems/districts/test_views.py

@@ -26,8 +26,8 @@ def test_template_name(self, view):
 
 @pytest.mark.django_db
 def test_district_view(client, model_District):
-    url = reverse("districts:district", kwargs={"district": 1})
+    url = reverse("districts:district", kwargs={"district_number": model_District.number})
     response = client.get(url)
 
     assert response.status_code == 200
-    assert response.context["district"] == model_District
+    assert response.context["current_district"] == model_District