This repository was archived by the owner on Sep 29, 2025. It is now read-only.
CI: deploy job runs only if tests pass #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that deploy does not run regardless of the success or failure of tests-ui and tests-pytest, i.e., needs actually behaves as expected
Coverage report
This PR does not seem to contain any modification to coverable code. |
thekaveman
approved these changes
Dec 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the
ifcondition on thedeployjob so that deploy does not run regardless of the success or failure oftests-uiandtests-pytest, i.e.,needsactually behaves as expected. Referred to the warning note in the docs.