Closed
Conversation
LionZXY
approved these changes
Feb 4, 2026
LionZXY
left a comment
LionZXY
left a comment
There was a problem hiding this comment.
We could use that too. I also really like the approach taken in this PR - non-invasive, preserving backward compatibility
Member
|
Thanks for the contribution, however we do not accept contributions to the public API. The changes in your PR gives an 'anchor' to the BottomSheet, which doesn't make sense from a semantics POV. However, I do agree that having a Top anchored sheet is very handy. How about you open an issue or discussion with your API proposal instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for top-anchored sheets via new SheetAnchor parameter, allowing BottomSheet and ModalBottomSheet to appear from top of screen and expands downward and being dismissed by swiping up
Test Plan
Related Issues
Screenshots/Videos