refactor(PullToRefresh): Refactor drag resistance and offset logic #157
+136
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the pull-to-refresh drag resistance mechanism to align with the `Overscroll` utility. Key changes: * Replaces the custom resistance calculation with `DefaultParabolaScrollEasing` for a more consistent feel. * Introduces `currentTouch` to track the raw pointer distance, separate from the visual `dragOffset`. * Renames `rawDragOffset` to `dragOffset` for clarity. * Simplifies the nested scroll connection by centralizing offset calculations into a new `addTouchDelta` function.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the pull-to-refresh drag resistance mechanism to align with the Overscroll utility, improving consistency and code maintainability.
Key changes:
- Replaces custom resistance calculation with
DefaultParabolaScrollEasingfor consistent drag behavior - Introduces
currentTouchto track raw pointer distance separately from the damped visualdragOffset - Centralizes offset calculations into a new
addTouchDeltahelper function for cleaner nested scroll handling
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
miuix/src/commonMain/kotlin/top/yukonga/miuix/kmp/basic/PullToRefresh.kt
Outdated
Show resolved
Hide resolved
miuix/src/commonMain/kotlin/top/yukonga/miuix/kmp/basic/PullToRefresh.kt
Outdated
Show resolved
Hide resolved
…Refresh.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…Refresh.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the pull-to-refresh drag resistance mechanism to align with the
Overscrollutility.Key changes:
DefaultParabolaScrollEasingfor a more consistent feel.currentTouchto track the raw pointer distance, separate from the visualdragOffset.rawDragOffsettodragOffsetfor clarity.addTouchDeltafunction.