arrow: Add missing protobuf as tool_requires #28902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using protobuf, protoc is run at build time. Without this change protoc will fail to run if protobuf is built with shared=true.
AbrilRBS
changed the title
AbrilRBS
reviewed
Nov 14, 2025
Contributor
franramirez688
left a comment
franramirez688
left a comment
There was a problem hiding this comment.
Thanks for this PR! 🙏
Looks great, but could you add the failure/success logs to your PR description before/after applying your fix? It helps a lot for reviewers and any other users 😁
Member
|
I can confirm that without this, building with After the fix, this now compiles as expected, but it needs a further fix for the repro option |
AbrilRBS
approved these changes
Nov 14, 2025
AbrilRBS
reviewed
Nov 17, 2025
| self.cpp_info.components["libarrow_substrait"].libs = [f"arrow_substrait{suffix}"] | ||
| self.cpp_info.components["libarrow_substrait"].requires = ["libparquet", "dataset"] | ||
| self.cpp_info.components["libarrow_substrait"].requires = ["libparquet"] | ||
| if self.options.dataset_modules: |
Member
There was a problem hiding this comment.
This fix is the result of:
- The user reproduction case points to using
-o="*:shared=True" -o="&:with_protobuf=True" -o="&:substrait=True" - But the
datasetcomponent is only created if theself.options.dataset_modulesis notFalse, and as the option isFalseby default, Conan raised an exception here because nodatasetcomponent existed. - The fix just adds the internal requirement when it makes sense
In fact, the proper fix would be to force dataset when substrait is used, as per the sourccode:
add_arrow_lib(arrow_substrait
CMAKE_PACKAGE_NAME
ArrowSubstrait
PKG_CONFIG_NAME
arrow-substrait
OUTPUTS
ARROW_SUBSTRAIT_LIBRARIES
SOURCES
${ARROW_SUBSTRAIT_SRCS}
SHARED_LINK_FLAGS
${ARROW_VERSION_SCRIPT_FLAGS} # Defined in cpp/arrow/CMakeLists.txt
SHARED_LINK_LIBS
arrow_dataset_shared
substrait
SHARED_INSTALL_INTERFACE_LIBS
ArrowDataset::arrow_dataset_shared
STATIC_LINK_LIBS
arrow_dataset_static
substrait
STATIC_INSTALL_INTERFACE_LIBS
ArrowDataset::arrow_dataset_static
PRIVATE_INCLUDES
${SUBSTRAIT_INCLUDES})But went for this as it seemed more direct, but happy to change the approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: *arrow/ **
When building with protobuf.
Motivation
Arrow uses protoc as a built tool.
When building with "*:shared=true" and options to enable protobuf and substrait, protoc can't find the shared libraries it needs to run.
Details
Adds a tool Require and build environment. Fixes the issue.
Add a 👍 reaction to pull requests you find important to help the team prioritize, thanks!