fcl: modernize + simplify cmake patch #8873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ghost
mentioned this pull request
|
I detected other pull requests that are modifying fcl/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
SpaceIm
force-pushed
the
fcl-modernize
branch
from
7a2dfb7 to
412528b
Compare
SpaceIm
changed the title
This comment has been minimized.
This comment has been minimized.
|
I've submitted the CMake patch upstream: |
This was referenced Jan 13, 2022
This comment has been minimized.
This comment has been minimized.
uilianries
previously approved these changes
Jan 17, 2022
SpaceIm
changed the title
SSE4
approved these changes
Jan 24, 2022
prince-chrismc
approved these changes
Jan 25, 2022
Sahnvour
pushed a commit
to Sahnvour/conan-center-index
that referenced
this pull request
Jan 30, 2022
* modernize * bump eigen & octomap * add fcl/0.7.0 * cleanup after merge of master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: lib/1.0
When
fclwas packaged the first time, imported targets ofeigen,libccdandoctomapwere not properly modeled incmake_find_package_*generators, leading to this ugly patch. Now it's far better and the patch can be simplified.conan-center hook activated.