Skip to content

Conversation

@pgrohs
Copy link

@pgrohs pgrohs commented May 30, 2022

Changelog: (Feature): Capture username and channel from conanfile.py

Closes #602

In case user or channel are not given to ConanMultiPackager via parameter or environment variable, both are taken from the recipe to build. The overcomes the necessity to repeat user and channel of the recipe in the build script. Furthermore, it enables the realization of custom channel-strategies in the recipe.

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.

@CLAassistant
Copy link

CLAassistant commented May 30, 2022

CLA assistant check
All committers have signed the CLA.

@uilianries
Copy link
Member

@pgrohs Thank you for your contribution. Please, check those failed test. It seems like your feature broke some of them. Probably you need to validate case where user and channel are used, but they are None.

@pgrohs
Copy link
Author

pgrohs commented Jun 3, 2022

@uilianries I have updated the PR. Could please run the test cases?

@uilianries
Copy link
Member

@pgrohs Sorry the delay. Starting it now

@pgrohs
Copy link
Author

pgrohs commented Jun 27, 2022

@uilianries Could you please try to run the CI pipeline again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Username redundant

3 participants