This repository was archived by the owner on Mar 13, 2026. It is now read-only.
do not change the order of the remotes#614
Open
Basti-D wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: (Bugfix):
Fixes #613
Do not change the order of the remotes by using the default value from the Conan API instead of -1 in
add_remotes_to_conan -> _add_remoteProbably in Remotesmanager._add_remote the default argument of
insertshould be changed toNoneinstead ofFalse. The ConanAPI usesNoneas a the default value.The default value
Falsegets treated differently thenNone.Falsegets interpreted as notNone, hence we go in the insert_by_index case.index = int(False) = 0`` Hence it will put always to the beginning. The current version usesindex=-1`` which does not push to the end. It pushes toend -1, i.e. 1 BEFORE the last element.`None` has it's own handling and adds the remote to the end of the remotes OrderedDict which should be the correct behavior [see remote_registry.py : Remotes._remotes].