Skip to content

Conversation

jeongseok-meta
Copy link
Contributor

@jeongseok-meta jeongseok-meta commented Mar 30, 2025

Pending Issues and PRs

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/nerfstudio/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Mar 30, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/nerfstudio/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/nerfstudio/meta.yaml:

  • ℹ️ Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15686285334. Examine the logs at this URL for more detail.

- msgpack_numpy >=0.4.8
- nerfacc ==0.5.2
- open3d >=0.16.0
- opencv-python-headless ==4.10.0.84
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the strict pinning necessary here? Just FYI, we do not have the fourth version number in conda-forge, see conda-forge/opencv-feedstock#408 .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. I've simply followed upstream: https://github.com/nerfstudio-project/nerfstudio/blob/v1.1.5/pyproject.toml#L36

Let me change this to 4.11.0.86 for now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also do not have 4.11.0.86, we only have 4.11.0 .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I'm fine with 4.11.0, but I see 4.11.0.86: https://anaconda.org/conda-forge/opencv-python-headless/files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, I have found that there are many dependencies missing in conda-forge. We might need to add them first.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I do not think it make a lot of sense for that package to exists, I will open an issue in the feedstock.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeongseok-meta
Copy link
Contributor Author

jeongseok-meta commented Mar 31, 2025

(moved to top description)

1 similar comment
@jeongseok-meta
Copy link
Contributor Author

jeongseok-meta commented Apr 1, 2025

(moved to top description)

@jeongseok-meta jeongseok-meta marked this pull request as ready for review June 14, 2025 18:27
@jeongseok-meta
Copy link
Contributor Author

@conda-forge/help-python, ready for review!

  1. The osx and win builds are failing due to missing dependencies, but I believe this is acceptable for a noarch package.

  2. The pip check has been disabled as it complains about missing dependencies, even though all mandatory dependencies (including those it claims are missing) are installed.

@ocefpaf
Copy link
Member

ocefpaf commented Jun 16, 2025

2. The pip check has been disabled as it complains about missing dependencies, even though all mandatory dependencies (including those it claims are missing) are installed.

Can you paste the full error here so we can investigate what is going on? Or just re-add pip-check and let us see the log.

@jeongseok-meta
Copy link
Contributor Author

@ocefpaf It was

nerfstudio 1.1.5 requires open3d, which is not installed.
nerfstudio 1.1.5 requires opencv, which is not installed.

and let me re-add pip-check as well

Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
@traversaro
Copy link
Contributor

@ocefpaf It was

nerfstudio 1.1.5 requires open3d, which is not installed.
nerfstudio 1.1.5 requires opencv, which is not installed.

and let me re-add pip-check as well

The second error should be fixed by https://github.com/conda-forge/staged-recipes/pull/29576/files#r2150140251 . For the first one, we probably need to make sure that open3d installs the correct pip metadata, with patches like https://github.com/conda-forge/vtk-feedstock/blob/1713540479157274111d6f33a7b22d6ed7202adc/recipe/build-base.sh#L171-L187 or https://github.com/conda-forge/opencv-feedstock/blob/29732915bcd4377cd115dad476cac92b544fc217/recipe/patches_opencv/0001-Add-installation-of-pip-metadata-from-cmake.patch . However, I am not familar enough with open3d to exactly know were to patch, so probably the easiest option is to temporary remove the open3d dependency from the pyproject.toml ?

@jeongseok-meta
Copy link
Contributor Author

The Linux build is now passing, by (1) fixing the package name for opencv and (2) removing the open3d dependency from pyproject.toml. Thank you for your help, @traversaro!

@jeongseok-meta
Copy link
Contributor Author

@ocefpaf, I would appreciate it if you could take another look at this PR

@ocefpaf ocefpaf merged commit a786292 into conda-forge:main Jun 16, 2025
4 of 7 checks passed
@jeongseok-meta jeongseok-meta deleted the nerfstudio branch June 16, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants