-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Add nerfstudio #29576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nerfstudio #29576
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/nerfstudio/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15686285334. Examine the logs at this URL for more detail. |
recipes/nerfstudio/meta.yaml
Outdated
- msgpack_numpy >=0.4.8 | ||
- nerfacc ==0.5.2 | ||
- open3d >=0.16.0 | ||
- opencv-python-headless ==4.10.0.84 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the strict pinning necessary here? Just FYI, we do not have the fourth version number in conda-forge, see conda-forge/opencv-feedstock#408 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure. I've simply followed upstream: https://github.com/nerfstudio-project/nerfstudio/blob/v1.1.5/pyproject.toml#L36
Let me change this to 4.11.0.86 for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also do not have 4.11.0.86, we only have 4.11.0 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I'm fine with 4.11.0, but I see 4.11.0.86: https://anaconda.org/conda-forge/opencv-python-headless/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, I have found that there are many dependencies missing in conda-forge. We might need to add them first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I do not think it make a lot of sense for that package to exists, I will open an issue in the feedstock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(moved to top description) |
1 similar comment
(moved to top description) |
@conda-forge/help-python, ready for review!
|
Can you paste the full error here so we can investigate what is going on? Or just re-add pip-check and let us see the log. |
@ocefpaf It was
and let me re-add pip-check as well |
Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
The second error should be fixed by https://github.com/conda-forge/staged-recipes/pull/29576/files#r2150140251 . For the first one, we probably need to make sure that open3d installs the correct pip metadata, with patches like https://github.com/conda-forge/vtk-feedstock/blob/1713540479157274111d6f33a7b22d6ed7202adc/recipe/build-base.sh#L171-L187 or https://github.com/conda-forge/opencv-feedstock/blob/29732915bcd4377cd115dad476cac92b544fc217/recipe/patches_opencv/0001-Add-installation-of-pip-metadata-from-cmake.patch . However, I am not familar enough with open3d to exactly know were to patch, so probably the easiest option is to temporary remove the open3d dependency from the |
The Linux build is now passing, by (1) fixing the package name for opencv and (2) removing the open3d dependency from |
@ocefpaf, I would appreciate it if you could take another look at this PR |
Pending Issues and PRs
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).