Skip to content

Conversation

@fourierrr
Copy link
Contributor

What this PR does / why we need it:
When re-converting overlaybd image, the mediaType of the manifest read from the database should be "application/vnd.docker.distribution.manifest.v2+json", but it is incorrectly set to "application/vnd.docker.image.rootfs.diff.tar".

note: This issue only occurs in the case of converting multi-architecture images, as only during this conversion is a new index manifest uploaded. In the case of converting single-architecture images, the manifest is not uploaded, and the process ends directly.

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
    no
  • Does this change require a documentation update?
    no
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
    no
  • Do all new files have an appropriate license header?
    no

@WaberZhuang
Copy link
Contributor

Thanks for the PR, please add your signature to the commit using git commit -s ... to pass the project checks.

Signed-off-by: fourierrr <fourierrr@gmail.com>
@liulanzheng liulanzheng added the ok-to-test Pull request is ok to run ci test label Oct 15, 2024
@liulanzheng liulanzheng merged commit d2698f7 into containerd:main Oct 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Pull request is ok to run ci test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants