Skip to content

Commit 16e16f9

Browse files
authored
Merge pull request #4234 from apostasie/2025-05-tigron-wait-fix
[DOC]: clarify corner case on Tigron WithFeeder
2 parents 074f396 + 7680b12 commit 16e16f9

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

mod/tigron/internal/com/command.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,7 @@ func (gc *Command) WithPTY(stdin, stdout, stderr bool) {
150150
// WithFeeder ensures that the provider function will be executed and its output fed to the command stdin.
151151
// WithFeeder, like Feed, can be used multiple times, and writes will be performed sequentially, in order.
152152
// This command has no effect if Run has already been called.
153+
// Note that if the `writer` function runs a forever loop, we will deadlock and just Wait() forever on the errgroup.
153154
func (gc *Command) WithFeeder(writers ...func() io.Reader) {
154155
gc.writers = append(gc.writers, writers...)
155156
}

0 commit comments

Comments
 (0)