Skip to content

Commit 77bb9b1

Browse files
authored
Merge pull request #76 from ktock/privateport
Fix auth error on pulling private image with "not well-knwon" port
2 parents 32c541f + 52732ed commit 77bb9b1

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

pkg/imgutil/dockerconfigresolver/dockerconfigresolver.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
package dockerconfigresolver
1919

2020
import (
21+
"net"
2122
"net/url"
2223

2324
"github.com/containerd/containerd/remotes"
@@ -78,7 +79,11 @@ func New(refHostname string) (remotes.Resolver, error) {
7879
if err != nil {
7980
return nil, errors.Wrapf(err, "failed to parse ac.ServerAddress %q", ac.ServerAddress)
8081
}
81-
if acsaHostname := acsaURL.Hostname(); acsaHostname != authConfigHostname {
82+
acsaHostname := acsaURL.Hostname()
83+
if acsaPort := acsaURL.Port(); acsaPort != "" {
84+
acsaHostname = net.JoinHostPort(acsaHostname, acsaPort)
85+
}
86+
if acsaHostname != authConfigHostname {
8287
return nil, errors.Errorf("expected the hostname part of ac.ServerAddress (%q) to be authConfigHostname=%q, got %q",
8388
ac.ServerAddress, authConfigHostname, acsaHostname)
8489
}

0 commit comments

Comments
 (0)