Merge pull request #1221 from manugupt1/add-debug-logs

AkihiroSuda · web-flow · commit cd73b090e2cb · 2022-07-13T14:07:57.000+09:00
Log matches of log paths to understand TestRunWithJsonFileLogDriver flakiness
diff --git a/cmd/nerdctl/run_test.go b/cmd/nerdctl/run_test.go
@@ -234,7 +234,7 @@ func TestRunWithJsonFileLogDriver(t *testing.T) {
 	matches, err := filepath.Glob(filepath.Join(logJSONPath, inspectedContainer.ID+"*"))
 	assert.NilError(t, err)
 	if len(matches) != 2 {
-		t.Fatal("the maximum number of old log files to retain exceeded 2 files")
+		t.Fatalf("the maximum number of old log files to retain exceeded 2 files, got: %s", matches)
 	}
 	for _, file := range matches {
 		fInfo, err := os.Stat(file)

Original file line number	Diff line number	Diff line change
`@@ -234,7 +234,7 @@ func TestRunWithJsonFileLogDriver(t *testing.T) {`
`234`	`234`	`matches, err := filepath.Glob(filepath.Join(logJSONPath, inspectedContainer.ID+"*"))`
`235`	`235`	`assert.NilError(t, err)`
`236`	`236`	`if len(matches) != 2 {`
`237`		`- t.Fatal("the maximum number of old log files to retain exceeded 2 files")`
	`237`	`+ t.Fatalf("the maximum number of old log files to retain exceeded 2 files, got: %s", matches)`
`238`	`238`	`}`
`239`	`239`	`for _, file := range matches {`
`240`	`240`	`fInfo, err := os.Stat(file)`