Properly surface errors from push command
#1259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failure exit code for `push` command is not currently forwarded as exit code for podman-compose. With this PR, podman-compose stops pushing when the underlying podman command fails and forwards its exit code. Signed-off-by: Monika Kairaityte <monika@kibit.lt>
Test is added to confirm that `run` command forwards non-zero failure exit code. Signed-off-by: Monika Kairaityte <monika@kibit.lt>
mokibit
force-pushed
the
push-non-zero-exit-code
branch
3 times, most recently
from
09bf7ce to
ed1159d
Compare
Renamed directory `build_fail_multi` to more appropriate `commands_fail_exit_code` as more tests were added to other commands:`push` and `run`. Names of tests were changed accordingly. Signed-off-by: Monika Kairaityte <monika@kibit.lt>
mokibit
force-pushed
the
push-non-zero-exit-code
branch
from
ed1159d to
b3fd550
Compare
p12tic
approved these changes
Jul 3, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the failure exit code from the
pushcommand is not forwarded as the exit code forpodman-compose.With this PR, failure exit code is correctly forwarded when the underlying
podmancommand fails.This PR completes PR #521, dealing with the
pushandruncommands as the same problem withbuildcommand was resolved by PR #1168.The
runcommand already correctly forwards failure exit codes, so only a test was added for it.