-
Notifications
You must be signed in to change notification settings - Fork 22
BETA: move everything to rollup #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
@@ -1,4 +1,4 @@ | |||
import { CreateHttpClientParams, DefaultOptions } from './types' | |||
import { CreateHttpClientParams, DefaultOptions } from './types.js' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
types.js
, bit of an oxymoron 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but we have to :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code changes look fine to me, I didn't clone/build/run/test/lint but I can if you think that you increase confidence.
We're planning to release a new major update with this change, correct?
Yes, it will be part of the upcoming major :) |
🎉 This PR is included in version 10.0.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
based on our learnings from CMA, batch-libs and import