Skip to content

Conversation

axe312ger
Copy link
Contributor

@axe312ger axe312ger commented Sep 17, 2025

based on our learnings from CMA, batch-libs and import

  • node v20
  • rollup now handles the whole build process
  • dependency cleanup

@axe312ger axe312ger requested a review from a team as a code owner September 17, 2025 10:19
@wiz-inc-38d59fb8d7
Copy link

wiz-inc-38d59fb8d7 bot commented Sep 17, 2025

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities 1 High
Data Finding Sensitive Data -
Total 1 High

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@@ -1,4 +1,4 @@
import { CreateHttpClientParams, DefaultOptions } from './types'
import { CreateHttpClientParams, DefaultOptions } from './types.js'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

types.js, bit of an oxymoron 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but we have to :D

Copy link

@ethan-ozelius-contentful ethan-ozelius-contentful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look fine to me, I didn't clone/build/run/test/lint but I can if you think that you increase confidence.

We're planning to release a new major update with this change, correct?

@axe312ger
Copy link
Contributor Author

code changes look fine to me, I didn't clone/build/run/test/lint but I can if you think that you increase confidence.

We're planning to release a new major update with this change, correct?

Yes, it will be part of the upcoming major :)

@whitelisab whitelisab merged commit 1a63a23 into beta Sep 29, 2025
7 checks passed
@whitelisab whitelisab deleted the build/everything-with-rollup branch September 29, 2025 19:25
@contentful-automation
Copy link

🎉 This PR is included in version 10.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants