-
Notifications
You must be signed in to change notification settings - Fork 16
feat: added support of show-console-logs flag in config:set:log command #2021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for a new show-console-logs
flag to the config:set:log command, allowing users to enable or disable console logging functionality.
- Added a new boolean flag
show-console-logs
with allowNo option for disabling via--no-show-console-logs
- Updated command logic to handle the new flag and persist it in configuration
- Enhanced test coverage with new test cases for the console logs functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
File | Description |
---|---|
packages/contentstack-config/src/commands/config/set/log.ts | Added show-console-logs flag definition, handling logic, and success messaging |
packages/contentstack-config/test/unit/commands/log.test.ts | Enhanced test suite with comprehensive coverage for the new flag functionality |
packages/contentstack-config/messages/index.json | Added new message keys for console logging and updated existing messages |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
cs-raj
approved these changes
Jul 25, 2025
shafeeqd959
reviewed
Jul 25, 2025
netrajpatel
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a new show-console-logs flag to the config:set:log command, allowing users to enable or disable console logging functionality.
Added a new boolean flag show-console-logs with allowNo option for disabling via --no-show-console-logs
Updated command logic to handle the new flag and persist it in configuration
Enhanced test coverage with new test cases for the console logs functionality
NOTE: Will do the version before the release