Skip to content

feat: added support of show-console-logs flag in config:set:log command #2021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 25, 2025

Conversation

aman19K
Copy link
Contributor

@aman19K aman19K commented Jul 25, 2025

This PR adds support for a new show-console-logs flag to the config:set:log command, allowing users to enable or disable console logging functionality.

Added a new boolean flag show-console-logs with allowNo option for disabling via --no-show-console-logs
Updated command logic to handle the new flag and persist it in configuration
Enhanced test coverage with new test cases for the console logs functionality

NOTE: Will do the version before the release

@aman19K aman19K requested a review from a team as a code owner July 25, 2025 11:29
@aman19K aman19K requested a review from Copilot July 25, 2025 11:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for a new show-console-logs flag to the config:set:log command, allowing users to enable or disable console logging functionality.

  • Added a new boolean flag show-console-logs with allowNo option for disabling via --no-show-console-logs
  • Updated command logic to handle the new flag and persist it in configuration
  • Enhanced test coverage with new test cases for the console logs functionality

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
packages/contentstack-config/src/commands/config/set/log.ts Added show-console-logs flag definition, handling logic, and success messaging
packages/contentstack-config/test/unit/commands/log.test.ts Enhanced test suite with comprehensive coverage for the new flag functionality
packages/contentstack-config/messages/index.json Added new message keys for console logging and updated existing messages

aman19K and others added 2 commits July 25, 2025 17:06
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@aman19K aman19K merged commit 6ed6d46 into development Jul 25, 2025
10 checks passed
@aman19K aman19K deleted the feat/DX-3286 branch July 25, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants