Skip to content

Commit 28e3856

Browse files
Reverted variant types fix and Update node version to 22
1 parent cc5b7c7 commit 28e3856

File tree

6 files changed

+62
-51
lines changed

6 files changed

+62
-51
lines changed

.github/workflows/npm-publish.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ jobs:
1010
publish-npm:
1111
runs-on: ubuntu-latest
1212
steps:
13-
- uses: actions/checkout@v3
14-
- uses: actions/setup-node@v3
13+
- uses: actions/checkout@v4
14+
- uses: actions/setup-node@v4
1515
with:
1616
node-version: '22.x'
1717
registry-url: 'https://registry.npmjs.org'
@@ -22,8 +22,8 @@ jobs:
2222
publish-git:
2323
runs-on: ubuntu-latest
2424
steps:
25-
- uses: actions/checkout@v3
26-
- uses: actions/setup-node@v3
25+
- uses: actions/checkout@v4
26+
- uses: actions/setup-node@v4
2727
with:
2828
node-version: '22.x'
2929
registry-url: 'https://npm.pkg.github.com'

lib/entity.js

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,17 @@ export const publishUnpublish = async (http, url, httpBody, headers, locale = nu
4444
try {
4545
const response = await http.post(url, httpBody, headers)
4646
if (response.data) {
47-
return response.data
47+
const data = response.data || {}
48+
if (headers) {
49+
data.stackHeaders = headers;
50+
}
51+
if (http?.httpClientParams?.headers?.includeResHeaders === true) {
52+
data.stackHeaders = {
53+
...data.stackHeaders,
54+
responseHeaders: response.headers,
55+
};
56+
}
57+
return data
4858
} else {
4959
throw error(response)
5060
}

package-lock.json

Lines changed: 41 additions & 41 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/typescript/variants.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { expect } from "chai"
22
import path from "path"
33
import { Stack } from "../../types/stack";
4+
import { Variant, Variants } from "../../types/stack/VariantGroup/variants";
45
import { variantEntry, variantEntry2 } from "./mock/variants";
56
var tokenUID = ''
67
export function createVariant(stack: Stack) {

types/stack/VariantGroup/variants/index.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import { AnyProperty, SystemFields } from "../../../utility/fields";
22
import { Queryable, SystemFunction } from "../../../utility/operations";
33

4-
export interface VariantGroupVariant extends SystemFields, SystemFunction<VariantGroupVariants> {
4+
export interface Variant extends SystemFields, SystemFunction<Variants> {
55

66
}
77

8-
export interface VariantGroupVariants extends Queryable<VariantGroupVariants, {variant: VariantData}> {
8+
export interface Variants extends Queryable<Variants, {variant: VariantData}> {
99

1010
}
1111

types/stack/index.d.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import { Taxonomy, Taxonomies } from "./taxonomy";
2222
import { ManagementToken, ManagementTokens } from "./managementToken";
2323
import { Variant, Variants } from "./variants";
2424
import { VariantGroup, VariantGroups } from "./VariantGroup";
25-
import { VariantGroupVariant, VariantGroupVariants } from "./VariantGroup/variants";
25+
import { Variant, Variants } from "./VariantGroup/variants";
2626

2727
export interface StackConfig {
2828
api_key:string
@@ -112,6 +112,6 @@ export interface Stack extends SystemFields {
112112
variantGroup(): VariantGroups
113113
variantGroup(uid: string): VariantGroup
114114

115-
variant(): VariantGroupVariants
116-
variant(uid: string): VariantGroupVariant
115+
variant(): Variants
116+
variant(uid: string): Variant
117117
}

0 commit comments

Comments
 (0)