Skip to content

Commit 32fb127

Browse files
Vikram KaltaVikram Kalta
Vikram Kalta
authored and
Vikram Kalta
committed
fix: variants types fixes
1 parent a5959b5 commit 32fb127

File tree

4 files changed

+8
-10
lines changed

4 files changed

+8
-10
lines changed

test/typescript/variants.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
import { expect } from "chai"
2-
import path from "path"
32
import { Stack } from "../../types/stack";
4-
import { Variant, Variants } from "../../types/stack/VariantGroup/variants";
53
import { variantEntry, variantEntry2 } from "./mock/variants";
64
var tokenUID = ''
75
export function createVariant(stack: Stack) {

types/stack/VariantGroup/index.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import { AnyProperty, SystemFields } from "../../utility/fields";
22
import { Queryable, SystemFunction } from "../../utility/operations";
3-
import { Variants, Variant } from "./variants";
3+
import { VariantGroupVariants, VariantGroupVariant } from "./variants";
44

55
export interface VariantGroup extends SystemFields, SystemFunction<VariantGroup> {
6-
variants(): Variants
7-
variants(variant: string): Variant
6+
variants(): VariantGroupVariants
7+
variants(variant: string): VariantGroupVariant
88
}
99

1010
export interface VariantGroups extends Queryable<VariantGroup, {uid: VariantGroupData}> {

types/stack/VariantGroup/variants/index.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import { AnyProperty, SystemFields } from "../../../utility/fields";
22
import { Queryable, SystemFunction } from "../../../utility/operations";
33

4-
export interface Variant extends SystemFields, SystemFunction<Variants> {
4+
export interface VariantGroupVariant extends SystemFields, SystemFunction<VariantGroupVariants> {
55

66
}
77

8-
export interface Variants extends Queryable<Variants, {variant: VariantData}> {
8+
export interface VariantGroupVariants extends Queryable<VariantGroupVariants, {variant: VariantData}> {
99

1010
}
1111

types/stack/index.d.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import { Taxonomy, Taxonomies } from "./taxonomy";
2222
import { ManagementToken, ManagementTokens } from "./managementToken";
2323
import { Variant, Variants } from "./variants";
2424
import { VariantGroup, VariantGroups } from "./VariantGroup";
25-
import { Variant, Variants } from "./VariantGroup/variants";
25+
import { VariantGroupVariant, VariantGroupVariants } from "./VariantGroup/variants";
2626

2727
export interface StackConfig {
2828
api_key:string
@@ -112,6 +112,6 @@ export interface Stack extends SystemFields {
112112
variantGroup(): VariantGroups
113113
variantGroup(uid: string): VariantGroup
114114

115-
variant(): Variants
116-
variant(uid: string): Variant
115+
variant(): VariantGroupVariants
116+
variant(uid: string): VariantGroupVariant
117117
}

0 commit comments

Comments
 (0)