Skip to content

fix: variants type naming fix #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2025
Merged

fix: variants type naming fix #247

merged 1 commit into from
Jan 21, 2025

Conversation

vkalta
Copy link
Contributor

@vkalta vkalta commented Jan 19, 2025

No description provided.

@vkalta vkalta requested a review from a team as a code owner January 19, 2025 20:11
sunil-lakshman
sunil-lakshman reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@sunil-lakshman sunil-lakshman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vkalta Did you test the type support?

@vkalta
Copy link
Contributor Author

vkalta commented Jan 20, 2025

@vkalta Did you test the type support?

Hi @sunil-lakshman , yes I did.

@vkalta vkalta closed this Jan 20, 2025
@vkalta vkalta reopened this Jan 20, 2025
sunil-lakshman
sunil-lakshman reviewed Jan 21, 2025
View reviewed changes
@vkalta vkalta merged commit a026c7e into development Jan 21, 2025
12 checks passed
@vkalta vkalta deleted the fix/1989 branch January 21, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunil-lakshman sunil-lakshman sunil-lakshman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vkalta @sunil-lakshman