Skip to content

fix: handle api_version chaining and ensure backward compatibility #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

sunil-lakshman
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Apr 8, 2025

Coverage report for commit: 4afaaa0
File: coverage/clover.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  10% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ █████████░░░░░░░░░░░░░░ │ 18.4%
  90% │ ███████████████████████ │ 46.9%
 100% │ █████████████████░░░░░░ │ 34.7%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution 
Summary - Lines: 89.34% | Methods: 98.58% | Branches: 72.40%
FilesLinesMethodsBranches
lib/app/authorization
   index.js91.67%100.00%72.09%
lib/app/hosting
   deployment.js85.29%100.00%65.79%
   index.js80.70%100.00%59.09%
lib/app
   index.js92.78%100.00%66.12%
lib/app/installation
   index.js84.62%100.00%59.55%
lib/app/request
   index.js91.43%100.00%65.85%
lib
   contentstack.js100.00%100.00%100.00%
   contentstackClient.js80.85%92.86%64.15%
   contentstackCollection.js94.12%100.00%93.33%
   entity.js83.33%100.00%67.67%
lib/core
   Util.js96.36%100.00%83.64%
   concurrency-queue.js86.01%87.18%76.00%
   contentstackError.js100.00%100.00%100.00%
   contentstackHTTPClient.js98.33%100.00%95.08%
   oauthHandler.js92.54%100.00%70.07%
lib/organization
   index.js83.33%100.00%60.67%
lib/organization/teams
   index.js92.11%100.00%68.42%
lib/organization/teams/stackRoleMappings
   index.js89.29%100.00%58.14%
lib/organization/teams/teamUsers
   index.js100.00%100.00%93.75%
lib/query
   index.js80.43%100.00%67.27%
lib/stack/asset/folders
   index.js100.00%100.00%100.00%
lib/stack/asset
   index.js93.06%100.00%81.18%
lib/stack/auditlog
   index.js95.83%100.00%75.00%
lib/stack/branch
   compare.js81.82%100.00%71.88%
   index.js97.44%100.00%80.56%
   mergeQueue.js100.00%100.00%73.68%
lib/stack/branchAlias
   index.js86.21%100.00%65.85%
lib/stack/contentType/entry
   index.js88.39%100.00%64.60%
lib/stack/contentType/entry/variants
   index.js86.21%100.00%68.57%
lib/stack/contentType
   index.js89.23%100.00%74.03%
lib/stack/deliveryToken
   index.js100.00%100.00%94.44%
lib/stack/environment
   index.js100.00%100.00%100.00%
lib/stack/extension
   index.js95.92%100.00%87.76%
lib/stack/globalField
   index.js94.59%100.00%82.22%
lib/stack
   index.js84.92%92.86%72.76%
lib/stack/label
   index.js100.00%100.00%100.00%
lib/stack/locale
   index.js100.00%100.00%100.00%
lib/stack/managementToken
   index.js100.00%100.00%94.44%
lib/stack/release
   index.js91.11%100.00%72.34%
lib/stack/roles
   index.js100.00%100.00%100.00%
lib/stack/taxonomy
   index.js88.00%100.00%64.52%
lib/stack/taxonomy/terms
   index.js92.31%100.00%72.55%
lib/stack/variantGroup
   index.js86.84%100.00%65.12%
lib/stack/variantGroup/variants
   index.js85.00%100.00%60.78%
lib/stack/variants
   index.js84.21%100.00%59.57%
lib/stack/webhook
   index.js89.66%100.00%72.88%
lib/stack/workflow
   index.js89.09%100.00%72.31%
lib/stack/workflow/publishRules
   index.js100.00%100.00%100.00%
lib/user
   index.js94.29%100.00%82.14%

🤖 comment via lucassabreu/comment-coverage-clover

@sunil-lakshman sunil-lakshman marked this pull request as ready for review April 9, 2025 06:46
@sunil-lakshman sunil-lakshman requested a review from a team as a code owner April 9, 2025 06:46
aman19K
aman19K previously approved these changes Apr 9, 2025
nadeem-cs
nadeem-cs previously approved these changes Apr 9, 2025
Copy link
Contributor

@nadeem-cs nadeem-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunil-lakshman Please add Changelog for this hotfix.

@sunil-lakshman sunil-lakshman dismissed stale reviews from nadeem-cs and aman19K via 5b0af75 April 9, 2025 07:45
@sunil-lakshman sunil-lakshman requested a review from nadeem-cs April 9, 2025 07:58
nadeem-cs
nadeem-cs previously approved these changes Apr 9, 2025
@sunil-lakshman sunil-lakshman changed the base branch from development to master April 11, 2025 10:00
@sunil-lakshman sunil-lakshman changed the base branch from master to development April 11, 2025 10:00
@sunil-lakshman sunil-lakshman deleted the hotfix/global_fields branch April 23, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants