diff --git a/.github/workflows/jira.yml b/.github/workflows/jira.yml index 5ddf87a..caa4bbd 100644 --- a/.github/workflows/jira.yml +++ b/.github/workflows/jira.yml @@ -3,7 +3,7 @@ on: pull_request: types: [opened] jobs: - security: + security-jira: if: ${{ github.actor == 'dependabot[bot]' || github.actor == 'snyk-bot' || contains(github.event.pull_request.head.ref, 'snyk-fix-') || contains(github.event.pull_request.head.ref, 'snyk-upgrade-')}} runs-on: ubuntu-latest steps: @@ -26,3 +26,8 @@ jobs: PR: ${{ github.event.pull_request.html_url }} fields: "${{ secrets.JIRA_FIELDS }}" + - name: Transition issue + uses: atlassian/gajira-transition@v3 + with: + issue: ${{ steps.create.outputs.issue }} + transition: ${{ secrets.JIRA_TRANSITION }} diff --git a/.github/workflows/sast-scan.yml b/.github/workflows/sast-scan.yml new file mode 100644 index 0000000..3b9521a --- /dev/null +++ b/.github/workflows/sast-scan.yml @@ -0,0 +1,11 @@ +name: SAST Scan +on: + pull_request: + types: [opened, synchronize, reopened] +jobs: + security-sast: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - name: Semgrep Scan + run: docker run -v /var/run/docker.sock:/var/run/docker.sock -v "${PWD}:/src" returntocorp/semgrep semgrep scan --config auto \ No newline at end of file diff --git a/.github/workflows/sca-scan.yml b/.github/workflows/sca-scan.yml index bf9c1eb..f09161f 100644 --- a/.github/workflows/sca-scan.yml +++ b/.github/workflows/sca-scan.yml @@ -3,7 +3,7 @@ on: pull_request: types: [opened, synchronize, reopened] jobs: - security: + security-sca: runs-on: ubuntu-latest steps: - uses: actions/checkout@master diff --git a/src/toRedactor.tsx b/src/toRedactor.tsx index 96c5135..6449121 100644 --- a/src/toRedactor.tsx +++ b/src/toRedactor.tsx @@ -375,9 +375,9 @@ export const toRedactor = (jsonValue: any,options?:IJsonToHtmlOptions) : string if (attrsJson['width']) { let width = attrsJson['width'] if (width.slice(width.length - 1) === '%') { - style = `width: ${allattrs['width']}; height: ${attrsJson['height'] ? attrsJson['height'] : 'auto'};` - } else { style = `width: ${allattrs['width'] + '%'}; height: ${attrsJson['height'] ? attrsJson['height'] : 'auto'};` + } else { + style = `width: ${allattrs['width']}; height: ${attrsJson['height'] ? attrsJson['height'] : 'auto'};` } } else { if (allattrs['width']) { diff --git a/test/expectedJson.ts b/test/expectedJson.ts index 1509588..52afccd 100644 --- a/test/expectedJson.ts +++ b/test/expectedJson.ts @@ -615,7 +615,7 @@ export default { ] } ], - "htmlUpdated": "

" + "htmlUpdated": "

" }, "7": { "html": "

this is link

paragraph with class

paragraph with id

", @@ -1909,6 +1909,97 @@ export default { } ] } + }, + "RT-154": { + "html": "

", + "json": [ + { + "type": "p", + "attrs": {}, + "uid": "67d60b59926c48b58cb6b5d899401c01", + "children": [ + { + "text": "" + } + ] + }, + { + "type": "reference", + "attrs": { + "asset-link": "https://dev16-images.contentstack.com/v3/assets/blt8ffa7e7de8b20283/blt5523ee02703e39f5/60dc421ee5e22614ef8dadfa/captain_pardip.jpg", + "default": true, + "asset-type": "image/jpg", + "display-type": "display", + "type": "asset", + "style": { + "height": "auto" + }, + "redactor-attributes": { + "asset_uid": "blt5523ee02703e39f5", + "src": "https://dev16-images.contentstack.com/v3/assets/blt8ffa7e7de8b20283/blt5523ee02703e39f5/60dc421ee5e22614ef8dadfa/captain_pardip.jpg", + "width": "24.193548387096776%", + "height": "auto", + "style": "width: 24.193548387096776; height: auto;" + }, + "width": 24.193548387096776 + }, + "uid": "fe969de8727c4074a23442a71b57ebb8", + "children": [ + { + "text": "" + } + ] + }, + { + "type": "p", + "attrs": {}, + "uid": "8c912298ad0a4a458c189f12603c05fb", + "children": [ + { + "text": "" + } + ] + }, + { + "type": "embed", + "attrs": { + "src": "https://www.youtube.com/embed/CSvFpBOe8eY", + "style": {}, + "redactor-attributes": { + "src": "https://www.youtube.com/embed/CSvFpBOe8eY" + } + }, + "uid": "26067652d613404b8091f6e83d7af301", + "children": [ + { + "text": "" + } + ] + }, + { + "type": "reference", + "attrs": { + "asset-link": "https://dev16-images.contentstack.com/v3/assets/blt8ffa7e7de8b20283/blta2aad0332073026c/60dc3bf8214cd714eebe026b/logo_1.jpg", + "default": true, + "asset-type": "image/jpg", + "display-type": "display", + "type": "asset", + "style": {}, + "redactor-attributes": { + "asset_uid": "blta2aad0332073026c", + "src": "https://dev16-images.contentstack.com/v3/assets/blt8ffa7e7de8b20283/blta2aad0332073026c/60dc3bf8214cd714eebe026b/logo_1.jpg", + "height": "auto" + } + }, + "uid": "d56e691f59ce4d35934c6aa9325188a2", + "children": [ + { + "text": "" + } + ] + } + ], + "htmlUpdated": "

" } - + } \ No newline at end of file diff --git a/test/toRedactor.test.ts b/test/toRedactor.test.ts index b336961..a3ba579 100644 --- a/test/toRedactor.test.ts +++ b/test/toRedactor.test.ts @@ -33,12 +33,10 @@ describe("Testing json to html conversion", () => { let testResult = isEqual(htmlValue, expectedValue['5'].html) expect(testResult).toBe(true) }) - it("Image and iframe conversion", () => { - let jsonValue = expectedValue["6"].json - - let htmlValue = toRedactor({ type: "doc", attrs: {}, children: jsonValue }) - let testResult = isEqual(htmlValue, expectedValue['6'].htmlUpdated) - expect(testResult).toBe(true) + it.each(["6", "RT-154"])("Image and iframe conversion", (index) => { + let jsonValue = expectedValue[index].json + let htmlValue = toRedactor({ type: "doc", attrs: {}, children: jsonValue }) + expect(htmlValue).toBe(expectedValue[index].htmlUpdated) }) it("Link ,divider and property conversion", () => { let jsonValue = expectedValue["7"].json