fix: environment variable parsing for URL formatted values #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venky0195
approved these changes
Nov 13, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in environment variable parsing where values containing colons (such as URLs) were incorrectly split. The fix refactors the parsing logic into a dedicated method that splits only on the first colon, preserving URL schemes and ports in the values.
- Extracted duplicate parsing logic into a reusable
parseEnvVariablesStringmethod - Fixed colon-splitting to only split on the first occurrence, preserving URL-formatted values
- Added test coverage for the URL parsing scenario
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/adapters/base-class.ts | Implemented new parseEnvVariablesString method that correctly handles values with colons (e.g., URLs) by splitting on first colon only, and refactored two existing parsing locations to use this shared method |
| src/adapters/base-class.test.ts | Added test case to verify environment variable parsing correctly handles URL-formatted values with multiple colons in the value portion |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dhruvparekh12
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: environment variable parsing for URL formatted values