fix: use config.yaml name for default Local Config profile#11110
Open
MumuTW wants to merge 4 commits intocontinuedev:mainfrom
Open
fix: use config.yaml name for default Local Config profile#11110MumuTW wants to merge 4 commits intocontinuedev:mainfrom
MumuTW wants to merge 4 commits intocontinuedev:mainfrom
Conversation
dosubot
bot
added
the
size:M
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="core/config/profile/LocalProfileLoader.ts">
<violation number="1" location="core/config/profile/LocalProfileLoader.ts:46">
P2: Falsy check on override content causes empty override files to fall back to global config and potentially assign the wrong profile title.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
The configYamlSchema requires both name and version fields. The test only provided name, causing parseConfigYaml to reject the config and falling back to the default "Local Config" title. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
An empty override file should not fall back to global config. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MumuTW
force-pushed
the
fix-local-config-name-11061
branch
from
ac7cc66 to
9d0b59a
Compare
Contributor
Author
|
Rebased onto latest |
…oadConfig mock The module-level afterEach with vi.restoreAllMocks() was running after every test, including those in the first describe block. This reset the mockDoLoadConfig spy, causing the second test to receive undefined from doLoadConfig and fail with "Cannot read properties of undefined (reading 'errors')".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.continue/config.yamlwhen loading the global local profileLocal Configfallback when the file is missing, unreadable, or unparseableLocalProfileLoaderregression test covering custom name plus fallback casesTesting
npm run -s vitest -- config/profile/LocalProfileLoader.vitest.ts(fails in this workspace due unresolved local package entry for@continuedev/config-yaml)Continue Tasks: 🔄 7 running — View all
Summary by cubic
Use the name from ~/.continue/config.yaml as the default Local Config profile title. Falls back to "Local Config" when the file is missing, unreadable, malformed, or the name is blank; empty override files no longer trigger a fallback.
afterEachto avoid resettingdoLoadConfigmocks.Written for commit 3b8ac55. Summary will update on new commits.