week of year berechnen #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floodoo
reviewed
Mar 13, 2024
| return DateTime.now().year == year; | ||
| } | ||
|
|
||
| int get weekOfYear { |
There was a problem hiding this comment.
Brauchen denke ich einen anderen Namen dafür. Wusste nicht direkt was damit gemeint ist
There was a problem hiding this comment.
weekOfTheYear oder andere vorschläge?
There was a problem hiding this comment.
.weekOfYear passt eigentlich, ist typisch z.B. in C#.
.week oder .day wäre noch schöner.
JPM84
reviewed
Mar 13, 2024
| DateTime date = DateTime(year, month, day); | ||
|
|
||
| // Berechne die differenz zum Beginn des Jahres | ||
| int dayOfYear = date.difference(DateTime(year, 1, 1)).inDays + 1; |
There was a problem hiding this comment.
Würde zwei extensions hieraus machen.
.dayOfYear
.weekOfYear
Ein Test wäre hier zwingend für einen Merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculation of week number in a year.