Skip to content

chore: unstub cancelCurrentAuthenticatorOperation#228

Open
ice-hades wants to merge 1 commit intocorbado:mainfrom
ice-blockchain:chore/proper-cancel-on-android
Open

chore: unstub cancelCurrentAuthenticatorOperation#228
ice-hades wants to merge 1 commit intocorbado:mainfrom
ice-blockchain:chore/proper-cancel-on-android

Conversation

@ice-hades
Copy link

  • Dart method cancelCurrentAuthenticatorOperation() was stubbed and returns without calling platform API;
  • Native Android side already has real cancellation via CancellationSignal.cancel() in MessageHandler;
  • Because Dart method is a no-op, app-side watchdog timeout cannot request native cancel;

With this fix Dart cancel method actually sends Pigeon call to Android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant