Skip to content

feat: allow multiple rule ids and/or filenames #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat: allow multiple rule ids and/or filenames #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4268596
feat: allow multiple rule ids and/or filenames
fzipi Jul 24, 2025
7f20ae7
fix: add helper funcs
fzipi Jul 24, 2025
0b85e52
fix: remove unused func
fzipi Jul 24, 2025
a2b1fb2
fix: update test error names
fzipi Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions cmd/regex_compare.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,10 @@ func performCompare(processAll bool, ctx *processors.Context) error {
if err != nil && len(chainOffsetString) > 0 {
return errors.New("failed to match chain offset. Value must not be larger than 255")
}
regex := runAssemble(filePath)
regex, err := runAssemble(filePath)
if err != nil {
return err
}
err = processRegexForCompare(id, uint8(chainOffset), regex, ctx)
if err != nil && errors.Is(err, &ComparisonError{}) {
failed = true
Expand All @@ -156,7 +159,10 @@ func performCompare(processAll bool, ctx *processors.Context) error {
return &ComparisonError{}
}
} else {
regex := runAssemble(path.Join(ctx.RootContext().AssemblyDir(), ruleValues.fileName))
regex, err := runAssemble(path.Join(ctx.RootContext().AssemblyDir(), ruleValues.fileName))
if err != nil {
return err
}
return processRegexForCompare(ruleValues.id, ruleValues.chainOffset, regex, ctx)
}
return nil
Expand Down
Loading
Loading