Skip to content

Conversation

@EsadCetiner
Copy link
Member

Proposed changes

Change image location for the anomaly scoring diagram to as_inbound.svg to display the image correctly.

Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
@theseion
Copy link
Contributor

theseion commented Dec 9, 2024

Oh yes, I remember. The link checker was failing, which is why I had made that change. @fzipi why does Hugo magically resolve that image in the subfolder but refuses to load it when referenced correctly as anomaly_scoring/as_inbound_no_fonts.svg?height=36em? If we could use that, the image would be rendered correctly on GitHub and the link checker would be happy.

@fzipi
Copy link
Member

fzipi commented Dec 9, 2024

Need to review this one.

Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi
Copy link
Member

fzipi commented Dec 10, 2024

I think the problem is the link checker for this particular url. Moved the page to work as a page bundle and now it seems to work. 🤷

@fzipi fzipi merged commit 6c059dc into coreruleset:main Dec 10, 2024
1 check passed
@theseion
Copy link
Contributor

Oh, I see. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants