Skip to content

Commit 12a293f

Browse files
committed
refactor(MultiSelect): cupdate tag delete button
1 parent c756b96 commit 12a293f

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

js/src/multi-select.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -511,7 +511,7 @@ class MultiSelect extends BaseComponent {
511511
tag.dataset.value = value
512512
tag.innerHTML = text
513513

514-
const closeBtn = document.createElement('span')
514+
const closeBtn = document.createElement('button')
515515
closeBtn.classList.add(CLASS_NAME_TAG_DELETE, 'close')
516516
closeBtn.setAttribute('aria-label', 'Close')
517517
closeBtn.innerHTML = '<span aria-hidden="true">&times;</span>'
@@ -655,10 +655,6 @@ class MultiSelect extends BaseComponent {
655655
return
656656
}
657657

658-
if (this._selection.length === 0 && (this._config.selectionType === 'tags' || this._config.selectionType === 'text')) {
659-
this._searchElement.removeAttribute('size')
660-
}
661-
662658
if (this._selection.length > 0 && !this._config.multiple) {
663659
this._searchElement.placeholder = this._selection[0].text
664660
this._selectionElement.style.display = 'none'

scss/forms/_form-multi-select.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,8 +211,9 @@
211211
}
212212

213213
.form-multi-select-tag-delete {
214+
padding: 0;
214215
margin-left: 6px;
215-
cursor: pointer;
216+
border: 0;
216217
}
217218

218219
.form-multi-select.show {

0 commit comments

Comments
 (0)